pulumi-community #contribute

Join the conversation Join Slack

contribute

rough-oil-1458

09/03/2018, 10:21 AM

I do make install, copy node modules to my project, npm rebuild, and have to rm -rf LICENSE

eager-area-86739

09/08/2018, 5:12 PM

Good people of Pulumi,

eager-area-86739

09/08/2018, 5:12 PM

How can I update the documentation?

eager-area-86739

09/08/2018, 5:13 PM

In the documentation page (https://pulumi.io/reference/pkg/nodejs/@pulumi/aws/lambda/#DotnetCore2d0Runtime) it is missing the .NET Core 2.1 runtime for AWS Lambda

eager-area-86739

09/08/2018, 5:13 PM

However the code has it: https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/lambda/runtimes.ts#L32

white-balloon-205

09/08/2018, 5:29 PM

The API docs should get updated every time there is a release of a new version of the libraries. I believe this enum value was added recently and will be part of the upcoming release - planned for early next week.

white-balloon-205

09/08/2018, 5:30 PM

Note that you should still be able to use .NET Core 2.1 even before the upcoming release by passing the string value directly (casting to any if needed in TypeScript).

adventurous-jordan-10043

09/11/2018, 11:22 AM

When does the team decide to tag a stable version like 0.15.1 ?

adventurous-jordan-10043

09/11/2018, 11:24 AM

I made the version bump on homebrew side but I'm looking into automating/integrating this process into the existing one.

white-balloon-205

09/11/2018, 1:30 PM

@adventurous-jordan-10043 There's no fixed schedule for new releases, but we've generally been targeting at least on release per month plus any necessary patch releases in between in cases where there are critical fixes. @bitter-oil-46081 What's the best way to automate the homebrew updates as part of the release process?

adventurous-jordan-10043

09/11/2018, 1:34 PM

The thing is that automating homebrew updates is not really important but at least I want to document the command I used to do it. And I don't really know where it should belong.

white-balloon-205

09/11/2018, 1:43 PM

@bitter-oil-46081 may have a better suggestion, but we should probably add a section on releases to

CONTRIBUTING.md

and include homebrew in that.

adventurous-jordan-10043

09/11/2018, 1:45 PM

ok thanks

bitter-oil-46081

09/11/2018, 6:15 PM

@bitter-oil-46081 may have a better suggestion, but we should probably add a section on releases to
CONTRIBUTING.md
and include homebrew in that.

Yeah, this sounds reasonable. @adventurous-jordan-10043, thanks for updating the formula, if you want to do a PR to

CONTRIBUTING.md

and add a little section on Homebrew that would be much appreciated. I had actually realized this morning that we would need to do that as part of the release, but didn't know what to do 🙂.

rough-oil-1458

09/11/2018, 11:12 PM

https://github.com/Smithx10/pulumi-triton

rough-oil-1458

09/11/2018, 11:13 PM

But ran into an issue, https://github.com/terraform-providers/terraform-provider-triton/blob/stable-website/triton/provider.go#L35 should be false.

rough-oil-1458

09/11/2018, 11:14 PM

so it generates __config.require instead of .get

white-balloon-205

09/12/2018, 12:08 AM

@rough-oil-1458 Interesting - did you want this to generate a

.require

in Pulumi, or to generate a

.get

? Note that we've actually made some changes in the latest

tfbridge

that will ensure that the environment variables used in these sorts of Terraform config do get read by the config system. Are you using the latest

pulumi-terraform

from master? That may have an impact on the code generation for this specific case.

rough-oil-1458

09/12/2018, 12:21 AM

.get

rough-oil-1458

09/12/2018, 12:21 AM

i figured that .require is directly from Required: true

rough-oil-1458

09/12/2018, 12:22 AM

I put an issue in the triton provider to have it changed to optional

rough-oil-1458

09/12/2018, 12:22 AM

because it should be.

rough-oil-1458

09/12/2018, 12:23 AM

https://github.com/terraform-providers/terraform-provider-triton/issues/118

white-balloon-205

09/12/2018, 12:23 AM

I believe that we should now be requiring only that the value is provided via either env vars or pulumi configuration. @microscopic-florist-22719 will know for sure. I assume that is what the