pulumi-community #contribute

contribute

rough-oil-1458

10/17/2018, 12:49 PM

I was thinking on working on that to use it at work, but don’t wanna waste cycles if that’s going to change

white-balloon-205

10/17/2018, 3:13 PM

@rough-oil-1458 take a look at https://github.com/pulumi/pulumi/pull/2026 which is WIP PR for Azure blob storage backend. Other backends should be able to build on top of similar foundations.

quiet-wolf-18467

10/17/2018, 5:54 PM

I've submitted some trivial PRs (2071/2072) where I use

os.Exit

(Will this break any remote locking?) as the only return seems to be errors

quiet-wolf-18467

10/17/2018, 5:54 PM

Perhaps somebody could help me understand better?

incalculable-sundown-82514

10/17/2018, 5:58 PM

@quiet-wolf-18467 thanks for the PRs! In general we try to avoid exiting from any code living in the

pkg

directory, since in theory they could be used as libraries

quiet-wolf-18467

10/17/2018, 6:00 PM

Yeah. I thought that might be the case. So how would I cancel execution without an error? 😃

incalculable-sundown-82514

10/17/2018, 6:00 PM

good question! 😄 . In general we have this problem throughout our codebase…

incalculable-sundown-82514

10/17/2018, 6:01 PM

Do you know of an idiomatic Go approach to this? I’m trying to do something like this (https://github.com/pulumi/pulumi/pull/1898) deep in the Pulumi engine but it doesn’t really help us at the layer you’re working at, near the CLI.

incalculable-sundown-82514

10/17/2018, 6:01 PM

Really what we want to do is signal that we’re “bailing” and don’t want to continue, but it’s explicitly not an error - we just want to exit.

quiet-wolf-18467

10/17/2018, 6:21 PM

Perhaps a

type UserCancellation struct

that implements

Error

and we check the type in the

diag

functions

quiet-wolf-18467

10/17/2018, 6:22 PM

I haven't done much with Cobra, so I'm guessing 😀

quiet-wolf-18467

10/19/2018, 8:18 AM

Could someone maybe use a "low hanging fruit" label on the simpler tasks, to help identify issues that are good for beginning contributors to learn the codebase? 🙂

👍 2

rough-oil-1458

10/21/2018, 12:56 AM

@white-balloon-205 https://github.com/pulumi/pulumi/pull/2026/files , we are keeping IsLocalBackendURL correct? Also pkg/backend/filestate/storage/local/bucket.go, seems to be outside the scope of azure?

rough-oil-1458

10/21/2018, 1:23 AM

Where should we specify the backend? Only "pulumi login --cloud-url" and "pulumi login --local"? Or should "pulumi login" take --consul, --azure Just wondering if --cloud-url will make sense to users if it's not a cloud backend.

quiet-wolf-18467

11/02/2018, 5:50 PM

I noticed there's an empty Docker Hub repository: https://hub.docker.com/r/pulumi/pulumi/

quiet-wolf-18467

11/02/2018, 5:50 PM

I assume this will change? 🙂

🤔 1

big-piano-35669

11/02/2018, 7:35 PM

Yes, we have a

Dockerfile

now in the Pulumi repo: https://github.com/pulumi/pulumi/blob/master/Dockerfile @white-balloon-205 and/or @bitter-oil-46081 may have thoughts on any plans to incorporate publishing images as part of our release process.

white-balloon-205

11/02/2018, 7:37 PM

👍 Re-opened https://github.com/pulumi/pulumi/issues/1991 to track publishing the docker image as part of our release workflow.

full-dress-10026

11/27/2018, 5:20 PM

I'm trying to get set up to work on a PR. After running

make ensure

in pulumi-cloud root dir, I get this message

/home/kenny/Forks/pulumi-cloud is not within a known GOPATH/src

. I'm not familiar with Go or go-dep. Is there a quick fix for this?

white-balloon-205

11/27/2018, 5:21 PM

Yeah - you'll need a Go installation, and to clone the repo into a GOPATH - most likely /home/kenny/go/src/github.com/pulumi/pulumi-cloud. This is a little unfortunate for this package which is mostly just JS - but the test harness we use is in Go.

full-dress-10026

11/27/2018, 5:23 PM

~/go

the default? I believe I have a go installation but

printenv GOPATH

prints nothing.

white-balloon-205

11/27/2018, 5:28 PM

Yeah - that's the default.

full-dress-10026

11/27/2018, 5:41 PM

Any idea why my IDE is telling me it

Cannot find module '@pulumi/cloud'

? Guessing it's related to the

peerDependencies

package.json

white-balloon-205

11/27/2018, 5:41 PM

Is this in your test project? You'll need to run

yarn link @pulumi/cloud

in that test project folder (after running

yarn install

white-balloon-205

11/27/2018, 5:41 PM

And possibly also

yarn link @pulumi/cloud-aws

full-dress-10026

11/27/2018, 5:42 PM

It's in pulumi-cloud.

full-dress-10026

11/27/2018, 5:42 PM

service.ts

full-dress-10026

11/27/2018, 5:42 PM

... after running

make ensure

white-balloon-205

11/27/2018, 5:42 PM

Have you done

make ensure

and

make

in the root?

full-dress-10026

11/27/2018, 5:43 PM

Not the latter. Will do that.