https://pulumi.com logo
Join Slack
Channels
Powered by Linen
contribute
  • h

    helpful-vegetable-35581

    07/03/2018, 9:09 PM
    Brilliant, will await contact 🙂
  • s

    stocky-spoon-28903

    07/03/2018, 9:12 PM
    Is it expected that if a non-org-member makes a pull request, the CI build will fail because of missing secret values?
  • s

    stocky-spoon-28903

    07/03/2018, 9:12 PM
    (Trying to work out if this is something I have done vs something to be expected)
  • b

    big-piano-35669

    07/03/2018, 10:26 PM
    No, although we've been chasing down these problems since launch, and there may be a few more still lingering. @bitter-oil-46081 is our expert here.
  • b

    big-piano-35669

    07/03/2018, 10:26 PM
    There are certainly places where CI validation will be different for fork flows versus topic branches for anything that requires our team's credentials.
  • b

    big-piano-35669

    07/03/2018, 11:36 PM
    @stocky-spoon-28903 what repo was this in?
    w
    s
    • 3
    • 2
  • h

    helpful-vegetable-35581

    07/05/2018, 2:26 PM
    I put together https://github.com/pulumi/pulumi-terraform/pull/195 as I was getting fields in substructures that had been marked Removed in the terraform schema. Not sure the approach used is the best so if the team want to propose a different way of handling that I'd be happy to rework it.
    b
    • 2
    • 2
  • s

    stocky-spoon-28903

    07/18/2018, 11:12 PM
    Is there a well-defined release cadence for the various cloud modules?
  • m

    microscopic-florist-22719

    07/18/2018, 11:22 PM
    We've generally done a release every sprint, which turns out to be be ~every 3-4 weeks.
  • s

    stocky-spoon-28903

    07/18/2018, 11:24 PM
    Ah cool. For testing/development stuff I can just pin to the GitHub repo but for e.g. released components I’ll wait until there is a release before updating to use new bits
    w
    b
    • 3
    • 2
  • b

    bitter-oil-46081

    07/19/2018, 12:38 AM
    Note that we have also been getting better about doing releases a tad more frequently (and something I’m working on now is to make it easy for anyone on the team to push a release). Usually we’ll look about once a week (Wednesday) and publish releases if there are interesting changes we have confidence in.
  • s

    stocky-spoon-28903

    07/23/2018, 4:55 PM
    Is there a particular version of 
    pulumi-terraform
    which is good to pin on?
    m
    • 2
    • 23
  • s

    stocky-spoon-28903

    07/24/2018, 8:28 PM
    Is there anything which needs upstreaming from the pulumi fork of the terraform provider into the hashicorp version?
  • m

    microscopic-florist-22719

    07/24/2018, 11:19 PM
    Which terraform provider in particular?
  • s

    stocky-spoon-28903

    07/25/2018, 2:50 AM
    AWS, sorry
  • s

    stocky-spoon-28903

    07/25/2018, 2:50 AM
    Doh, thought I had mentioned that
  • m

    microscopic-florist-22719

    07/25/2018, 2:53 AM
    Here's the raw diff against the current merge base of 
    pulumi-master
    and upstream: https://github.com/pulumi/terraform-provider-aws/compare/455093e92d78aebc8f94abf076e025a4094a2707...pulumi-master
  • m

    microscopic-florist-22719

    07/25/2018, 2:56 AM
    It looks like the most important changes are: - ECR credentials data source https://github.com/pulumi/terraform-provider-aws/commit/105f6dd3297d92c53f3a3a8eaeb14f3d7ff1fa3b - CloudFront distro defaults: https://github.com/pulumi/terraform-provider-aws/commit/7d0b1ed843fd09ca01be09a2003415754dd85071 - Clean up lingering lambda ENIs: https://github.com/pulumi/terraform-provider-aws/commit/fa7e5750f5b6109cb2e59e0cdc6dd316c47b0575 - Handle role removal correctly: https://github.com/pulumi/terraform-provider-aws/commit/2265349c2ee4f261213c171d86627de70abe5b8d - Additional retries: https://github.com/pulumi/terraform-provider-aws/commit/b211842a47deba4d5cab6b66946238b61dac8331 - VPC link fixes: https://github.com/pulumi/terraform-provider-aws/commit/2b700354adb92553a321687a7aac717f34ecf95d - ECS health check waits: https://github.com/pulumi/terraform-provider-aws/commit/88178bc93ee227858addf3ed409b64f9a9b8b14e
  • m

    microscopic-florist-22719

    07/25/2018, 2:59 AM
    (the latest merge base is 455093e92d78aebc8f94abf076e025a4094a2707, which is about 3 weeks old)
  • a

    adventurous-jordan-10043

    08/02/2018, 1:26 PM
    When trying to make
    -.txt
  • a

    adventurous-jordan-10043

    08/02/2018, 1:29 PM
    gometalinter --install output doesnt include it
  • a

    adventurous-jordan-10043

    08/02/2018, 1:29 PM
    -.txt
  • a

    adventurous-jordan-10043

    08/02/2018, 1:29 PM
    I'm also wondering if I can get a full pulumi cli binary without running the linting part ?
  • s

    stocky-spoon-28903

    08/02/2018, 1:30 PM
    @adventurous-jordan-10043 You might want want to check that 
    gometalinter
    is up to date, I think 
    gas
    was added somewhat recently
  • s

    stocky-spoon-28903

    08/02/2018, 1:31 PM
    Sorry, that’s not the issue, I was remembering incorrectly. It got renamed to 
    gosec
  • s

    stocky-spoon-28903

    08/02/2018, 1:31 PM
    So if you have an up-to-date 
    gometalinter
    it won’t find 
    gas
  • s

    stocky-spoon-28903

    08/02/2018, 1:31 PM
    https://github.com/alecthomas/gometalinter/commit/445bce7956d2cd3b792db2ce3323d4fd31aa7d80
  • a

    adventurous-jordan-10043

    08/02/2018, 1:33 PM
    The best way to correct things is to bump 
    gometalinter
    on pulumi side or for me to downgrade ?
  • s

    stocky-spoon-28903

    08/02/2018, 1:34 PM
    Probably to bump on the pulumi side IMO (in the interests of keeping all the things up to date all the time), but I can’t speak for the team there
  • a

    adventurous-jordan-10043

    08/02/2018, 1:34 PM
    Yep for sure
Title
a

adventurous-jordan-10043

08/02/2018, 1:34 PM
Yep for sure
View count: 1