is it intentional to have the instancestate attribute/modifier for ec2 under transitgateway instead of ec2? https://www.pulumi.com/registry/packages/aws/api-docs/ec2transitgateway/instancestate/

No this looks like an oversight. Can you add an issue to pulumi-aws?

done! https://github.com/pulumi/pulumi-aws/issues/2814