Hi again we have an ongoing discussion regarding the correct

Question

Hi again we have an ongoing discussion regarding the correctness of resource types Docs here suggest that valid syntaxes are ` lt package gt lt module gt lt typename gt ` we implement this and fail validation at compile time if string doesn t match this pattern and ` lt package gt lt typename gt ` where this implies ` lt package gt index lt typename gt ` we don t support this yet hence the discussion Introspection into your code and into codegen integration tests suggests that actually supported shorthand pattern is not ` lt package gt lt typename gt ` but ` lt package gt lt typename gt ` with empty module segment This is further corroborated by metaschema here which suggests this regex `^ a zA Z a zA Z0 9 ^0 9 a zA Z0 9 ^0 9 a zA Z0 9 $` which also allows `x y z` and `x z` but not `x z` Is documentation misguided here

echoing-dinner-19531 · Answer

` lt package gt lt typename gt ` will cause inconsistencies in other parts of the system so that definitely can t be the right answer here Having said that it wouldn t surprise me if parts of the system were trying to do that and just resulting in slightly incorrect answers that hadn t been picked up on The metaschema and token validation are broken if they re accepting pkg typ but not pkg typ I ll dig in and see if we can straighten this out I ve been looking into this area this week anyway e g <https github com pulumi pulumi pull 14441> to check that isn t used in component type names

quaint-spring-93350 · Answer

Well ` lt package gt lt typename gt ` is exactly what works and is implemented in the core scream

echoing-dinner-19531 · Answer

yup but will break URNs because they split at markers

quaint-spring-93350 · Answer

Ok so the proper way will be ` lt package gt lt module gt lt typename gt ` or ` lt package gt lt typename gt ` where this implies ` lt package gt index lt typename gt ` right I think if you introduce this change now a lot of stuff will break on your side For instance we have just ported integration tests for codegen to failproof it and check what s missing and I think most of those tests use this format ` mypkg Resource `

quaint-spring-93350 · Answer

We found about this when these exact tests failed to compile due to ``` error A component resource must register a unique type name with the base constructor for example `pkg index MyComponent` error To reduce the potential of other type name conflicts this name contains the package and module name in addition to the type lt package gt lt module gt lt type gt error These names are namespaced alongside non component resources such as `aws lambda Function` error ctx registerResource Resource ResourceArgs mypkg Resource name args opts error ^^^^^^^^^^^^^^^^^``` That s a compilation error resource type strings are validated in compile time on our side and the error message is oriented towards end users because we assumed it s impossible for schemas to contain invalid resource types and even if they did we will get this error and understand what it means anyhow

echoing-dinner-19531 · Answer

Yeh it s a mess yeh I think it s going to break stuff but also it s currently breaking URNs and names so were going to have to figure it out