Hi,
I have a weird behavior when I want to upgrad...
# package-authoringt
thankful-match-46035
03/13/2024, 6:47 AMHi,
I have a weird behavior when I want to upgrade the provider to our latest version of our TF provider.
I’m executing upgrade provider script:
$ upgrade-provider ovh/pulumi-ovh--- Set Up Environment ---- GOWORK=off- PULUMI_MISSING_DOCS_ERROR=false- PULUMI_EXTRA_MAPPING_ERROR=true--- done ---...provider/resources.goe
enough-garden-22763
03/13/2024, 9:11 PMHi Aurelie, does the error happen if you run
make tfgenupgrade-providerenough-garden-22763
03/13/2024, 9:12 PMMy guess would be that something in upgrade-provider is managing branching in a way that wipes out your local edits to provider/resources.go ; but if it's something else I'd be really curious to have a look, never seen this particular problem before of edits to provider/resources.go not being repected.
t
thankful-match-46035
03/14/2024, 7:01 AMmake tfgenthankful-match-46035
03/14/2024, 7:30 AMI created a fresh new devpod environment , re executed upgrade provider tool and now it’s working.
The PR have been created.
thankful-match-46035
03/14/2024, 10:01 AMbut ... the GH action fails
a
adorable-house-61348
03/14/2024, 10:07 AMHi @thankful-match-46035, I suspect you have a toolchain directive in your
go.modgo.modt
thankful-match-46035
03/14/2024, 10:33 AMafter fixing the go verson in th Gh action it worked
thankful-match-46035
03/14/2024, 10:34 AMAlmost every upgrade provider is not smooth 😞
this time, the pulumi provider and bridge versions upgraded, with go 1.21, so I needed to update the go version in several files in my repository.
e
enough-garden-22763
03/14/2024, 3:03 PMReally appreciate this feedback, it resonates, we're still very far from a hassle-free experience on these upgrades.
enough-garden-22763
03/14/2024, 3:06 PMCan we capture any of these recent round of issues into tickets? Sounds like there was a problem with the toolchain directive and Go versions, and the other problem was with the workflow of 1. edit resources.go 2. run upgrade-provider 3. hit tfgen errors 4. go to step 1 where it would not pick up the errors?
b
big-architect-71258
03/14/2024, 6:05 PMI've the suspicion that a (half-way) smooth upgrade of a provider including an upgrade of GO requires https://github.com/pulumi/ci-mgmt. Or at least some features of it, that must run in the provider repo.
e
enough-garden-22763
03/14/2024, 7:08 PMDo you think of something in particular for this case, like ci-mgmt controlling the pinned version of the environment (Go version)?
b
big-architect-71258
03/14/2024, 7:19 PMExactly, because
ci-mgmte
enough-garden-22763
03/14/2024, 9:30 PMCould we factor out the setup of dependencies so we version it separately? This is always a little tricky since there's no one-size-fits-all tooling. We currently cannot adopt containers for this because some of the larger providers struggle with a container overhead. The GitHub Action native way seems to be
setup-fooenough-garden-22763
03/14/2024, 9:33 PMWe critically depend on ci-mgmt for internal operations right now and it's a bit too unwieldy to reuse for community, but if we find ways to carve out functionality into well-defined blocks I can see us evolving ci-mgmt to become simpler by reusing those blocks while still remaining operational.
enough-garden-22763
03/15/2024, 5:43 PMI just filed https://github.com/pulumi/upgrade-provider/issues/257 this is something I can reproduce that definitely feels very off, I think this might have been responsible for wiping the source changes
b
big-architect-71258
03/15/2024, 5:45 PMHowever I am finding that the default settings wipe out any changes, and checkout@enough-garden-22763 OUCH! 😮🔥, including wiping out any local changes tomaincompared tomain.origin/main
3 Views