https://pulumi.com logo
Join Slack
Powered by
<@UKHFQ233Q> <@UMP2PT80L> <@U04LG89SXS8> could one...
# pulumiverse
l
@big-architect-71258 @elegant-window-55250 @cuddly-flower-91328 could one of you process this one as soon as you can? https://github.com/pulumiverse/infra/pull/228
b
@limited-rainbow-51650 👀 will check on it
@limited-rainbow-51650 Seems the PR needs adjustments to the code which creates the labels
l
I didn't change the code. 🤷🏼
b
I mean the code doesn't create unique names for the label resources. Or do I misinterpret the error.
This is bonkers anyway 
pulumi-matchbox_label_[object Object]
seems that an object is put into the formatting string to create the label.
l
Could it be because my labels contain a 
/
in them? These labels are needed for 
upgrade-provider
.
b
As I said the code is buggy. The format string receives the complete 
label
object. This was never detected because you are the first to create explicit labels on a repo.
Okay, changing line 84 in 
repositories.ts
like so `new github.IssueLabel(`${name}_label_${label.name}`` did the trick. But I'm wondering why the 
purrl
repo gets a label deleted!?!?
l
b
Ahh ... it recreates the label because the resource name changed. And obviously you're not the first with creating labels on a repo.
l
I think the Pulumi resource name should use a cleaned up 
label.name
.
b
I'm wondering if we get into troubles if we don't replace the 
/
l
E.g. 
kind/enhancement
-> 
kind_enhancement
b
Yep I thought the same.
It hurts my eyes 😄 but that should do it. Right?
But I think we must replace ALL separators used in the Pulumi URI. So 
:
must be replaced as well. And 
$
=
. Some more?
l
That's a good start!
b
What's the best way to add the required code changes to your PR?
Or shall I create a separate one and you do a rebase on the new main HEAD?
l
Take my code in a PR of yours and you are also rid of the fork problem.
b
Just because I'm curious. I copied your changes to the main branch manually. Is there a better way to do that with GitHub i.e. "making a PR my PR"?
l
No. sad panda
b
Gnarf 😏
Please review my PR. I'll close yours.
l
I approved, but I'm no longer an org owner so my vote doesn't really count anymore
b
I know, but it was important to me that the PR contains your changes correctly as intended by you.
LOL 😄 Could it be because of the 
/
in the label name??? If so: those labels are illegal or must encoded in some way.
l
No, token is not correct. 
403
on all resources...
b
I can check the token tomorrow. but I doubt it's because the token has incorrect settings. I'll let you know.
@limited-rainbow-51650 Okay, according to my documentation that I created when you handed me over the Pulumiverse org the ADMIN token does not have any rights to manage labels. My bad 👎🏻 I'll create a new token.
Wondering why changing the permissions of a fine-grained token does not create a new request that has to be approved by an org-admin. Is that really secure???? Or is it because I'm an org admin?
@limited-rainbow-51650 finished
l
🙌🏼
5 Views
Open in Slack
PreviousNext
Powered by