https://pulumi.com logo
#kubernetes
Title
# kubernetes
g

gifted-beach-2614

11/19/2020, 7:20 PM
hey all, was looking over some of the diff logic in the provider and noticed what seems like a bug to me - i think this call should be
labelSelectorForceNewProperties(".spec.selector")
instead, since `matchLabels`/`matchExpressions` are fields inside LabelSelector, not directly inside the PVC spec object
just a typo or am i reading this wrong and it’s actually correct?
g

gorgeous-egg-16927

11/19/2020, 9:52 PM
You’re right, that is a bug. Would you mind filing an issue or contributing a PR?
g

gifted-beach-2614

11/19/2020, 10:28 PM
i can open a PR, sure - the label selector fields need to be added to the workload resources as well
🙏 1
as a followup, any chance we could get a new provider release cut with this commit?
g

gorgeous-egg-16927

12/01/2020, 7:54 PM
Yes, I’m expecting to cut a release in the next day or two.
We also publish dev builds, so you could use that in the meantime if you’re blocked
g

gifted-beach-2614

12/01/2020, 8:11 PM
👍 sounds great, thanks!
g

gorgeous-egg-16927

12/03/2020, 11:51 PM
g

gifted-beach-2614

12/04/2020, 3:25 PM
🎉 thank you!
5 Views