https://pulumi.com logo
Join Slack
Powered by
This message was deleted.
# azure
s
This message was deleted.
g
Hi, can you share the code you're using for the diagnostic settings?
a
Sure:
Copy code
Sure:
law = azure_native.operationalinsights.Workspace(
    resource_name("log-workspace"),
    resource_group_name=resource_group.name,
    retention_in_days=365,
    sku=azure_native.operationalinsights.WorkspaceSkuArgs(
        name=azure_native.operationalinsights.WorkspaceSkuNameEnum.PER_GB2018
    ),
    workspace_name=resource_name("log-workspace")
)

kv_diag_settings = azure_native.insights.DiagnosticSetting(
    "kvDiagnosticSetting",
    resource_uri=kv.id,
    log_analytics_destination_type="Dedicated",
    logs=[azure_native.insights.LogSettingsArgs(
        category="AuditEvent",
        enabled=True,
        retention_policy=azure_native.insights.RetentionPolicyArgs(
            days=365,
            enabled=True
        ),
    )],
    metrics=[azure_native.insights.MetricSettingsArgs(
        category="AllMetrics",
        enabled=True,
        retention_policy=azure_native.insights.RetentionPolicyArgs(
            days=365,
            enabled=True
        ),
    )],
    name="kvDiagnosticSetting",
    workspace_id=law.id
)

adf_diag_settings = azure_native.insights.DiagnosticSetting(
    "adfDiagnosticSetting",
    resource_uri=adf.id,
    log_analytics_destination_type="Dedicated",
    logs=[azure_native.insights.LogSettingsArgs(
        category="PipelineRuns",
        enabled=True,
        retention_policy=azure_native.insights.RetentionPolicyArgs(
            days=365,
            enabled=True
        ),
    ),
        azure_native.insights.LogSettingsArgs(
            category="TriggerRuns",
            enabled=True,
            retention_policy=azure_native.insights.RetentionPolicyArgs(
                days=365,
                enabled=True
            ),
        ),
        azure_native.insights.LogSettingsArgs(
            category="ActivityRuns",
            enabled=True,
            retention_policy=azure_native.insights.RetentionPolicyArgs(
                days=365,
                enabled=True
            ),
        )],
    metrics=[azure_native.insights.MetricSettingsArgs(
        category="AllMetrics",
        enabled=True,
        retention_policy=azure_native.insights.RetentionPolicyArgs(
            days=365,
            enabled=True
        ),
    )],
    name="adfDiagnosticSetting",
    workspace_id=law.id
)
adf
, 
kv
and 
resource_group
are Pulumi resources, Data Factory, KeyVault and a Resource Group respectively.
g
Is it each of the 
DiagnosticSetting
resources that fails or just one of them?
a
The first one fails and never continues with the second one.
Well, the resource is created, just not saved to the state and then throws an error it already exists. Like Schrödinger's cat: It exists, but doesn't exist 😅
g
Hehe, got it. I'm looking into this and will get back to your shortly.
a
Thanks!
Maybe a small note: If we use a local storage during our CI pipeline both diagnostic settings are created, but neither end up in the state and the error about the resources (one of them) already existing remains. The fact that a storage container backend gives different results than using a local storage might help 🙂.
g
Local storage as in 
pulumi login --local
?
a
Yes
So, we’ve did some more investigation and it appears to be a problem in Azure. It appears that if you delete a resource that has a diagnostic settings attached to it the diagnostic settings is left dangling in Azure. Even if you delete the Log Analytics workspace AND the entire resource group. If you later on recreate the resources with the same name the diagnostic setting magically re-attaches without being re-created. If you explicitly delete the setting first, the problem goes away. We’re now going to check if 
pulumi destroy
will clean it up properly.
b
Hi Tim, Cameron asked me to look at this problem this morning. Just to clarify, do you think that you'd deleted a resource earlier that left the settings dangling and then re-created the new resource? Did you do this with pulumi or the Azure portal?
a
Hi Piers, The dangling resource happened when we manually delete all or some of the resources. We’ve now checked with 
pulumi destroy
as well and it appears Pulumi does it correctly and removes everything, including the diagnostic! (another reason to use Pulumi 😉 ) So this is purely an Azure (maybe Portal only, we didn’t check the CLI) thing.
b
That's great news! Let me or Cameron know if you have any more questions 😄
a
Will do, thanks for helping out!
13 Views
Open in Slack
PreviousNext
Powered by