<@U84SY03DF> How do you feel about adding function...
# generals
stocky-spoon-28903
07/14/2018, 5:42 PM@big-piano-35669 How do you feel about adding functions for common policy type templates to
pulumi-awsstocky-spoon-28903
07/14/2018, 5:44 PMFor example, every role has the
assume_role_policystocky-spoon-28903
07/14/2018, 5:45 PMSo, something like this might be good: https://github.com/pulumi/pulumi-aws/compare/master...jen20:assume-role-policy-function?expand=1
b
big-piano-35669
07/14/2018, 5:46 PM
I love it. We have the beginnings of some helpers here, https://github.com/pulumi/pulumi-aws/blob/master/overlays/nodejs/iam/documents.ts, that give you TypeScript schema, so at least you get type-checking. There are three missing pieces, though
1. It's incomplete
2. As you say, factory functions could really cut down on boilerplate
3. The resource types, for the most part, still take JSON serialized strings, so you can't just pass instances directly
To fully address 3, we'd need to do https://github.com/pulumi/pulumi-terraform/issues/10, which I know @microscopic-pilot-97530 had looked into at some point but I don't think we ever made progress.
s
stocky-spoon-28903
07/14/2018, 5:48 PMI’ll open a pull request for that change then - it’s added to
documentJSON.stringify(assumeRolePolicyForPrincipal("whatever"))👍 2
stocky-spoon-28903
07/14/2018, 5:49 PMI’ve written that function in terms of the
PolicyDocumentPrincipaldocument.ts