Title
s

stocky-spoon-28903

08/25/2018, 7:53 PM
Is the GitHub app open source? That looks like it has most of the basic bits in it for doing what I want for CodeBuild as an alternative to Travis CI
c

colossal-beach-47527

08/25/2018, 7:56 PM
It is not, and pretty deeply tied to our Pulumi Service. But I’m happy to share the details with you, but until we offer general webhook support I don’t think you’d be able to create something similar. (As you wouldn’t get the notification when the stack was updated and/or its update results.)
s

stocky-spoon-28903

08/25/2018, 7:58 PM
Right, my backup plan was to write a thing that accepts the GitHub webhooks, runs Pulumi in codebuild and then parses the logs of that to post back, effectively giving the Terraform Enterprise workflow for Pulumi.
Do you know if there’s a roadmap item in the nearish future to support CodeBuild in addition to Travis? If so I might be able to punt on this for a while
c

colossal-beach-47527

08/25/2018, 8:01 PM
Re: Supporting CodeBuild in addition to Travis, there is no roadmap item. But depending on what you mean by that, it would be ~5m if work.
s

stocky-spoon-28903

08/25/2018, 8:02 PM
Basically I want the entire workflow of the GitHub app exactly as it is, but for the compute that uses Travis to use CodeBuild (or even a Fargate job) instead
c

colossal-beach-47527

08/25/2018, 8:03 PM
The GitHub app associates preview and updates with GitHub IFF the job was ran as part of CI. (That’s how we don’t post previews ran on a dev box to PRs and things by mistake.) The way we support Travis is really just a matter of checking if some env vars are present, and then adding some additional metadata to the update. So we can tag Pulumi updates that are ran on CodeBuild in the same way. I’ll set a reminder to do that today, once my two little boys are in bed.
Let me find the line of code, since that will make this all much clearer...
s

stocky-spoon-28903

08/25/2018, 8:04 PM
Ahhhhh I see. That would be great. If there are just a bunch of envvars to set I guess it wouldn’t be too hard to just replicate them in CodeBuild?
c

colossal-beach-47527

08/25/2018, 8:08 PM
It’s more the other way around. Checking for the CodeBuild env vars, and then sending the data to Pulumi. I’m on mobile and cant find the code, but look in the Pulumi:Pulumi repo for the string ‘“TRAVIS”’. That should be the place where we read that env var and set some data in the update metadata.
I don’t recall the exact set of things the Pulumi Service needs before it will have the update be written to the GitHub app, but it should just be a matter of adding the “this update was ran on a CI system” bit. Super easy to add.
s

stocky-spoon-28903

08/25/2018, 8:11 PM
Thanks
I’ll take a look now
c

colossal-beach-47527

08/25/2018, 8:11 PM
No problem, thanks for mentioning it!
s

stocky-spoon-28903

08/25/2018, 8:17 PM
c

colossal-beach-47527

08/25/2018, 8:20 PM
Yes, exactly. If we just add a similar set of checks to populate those metadata properties for CodeBuild-based builds, everything should “just work”(TM).
s

stocky-spoon-28903

08/25/2018, 8:44 PM
Heh of course they can’t make it easy by mirroring the Travis options…
Looks like you have to match
CODEBUILD_GIT_BRANCH
with
pr-*
to find whether you’re on a pull request or not.
Heh, where
CODEBUILD_GIT_BRANCH
is determined by using
git symbolic-ref
on the supplied SHA 🤦‍♂️
c

colossal-beach-47527

08/25/2018, 8:47 PM
That bit is actually really important, at least on Travis. As the GitHub PR is at commit X in branch Y. But the CI build runs on some merge commit that GitHub doesn’t provide IIRC. I don’t know if CodeBuild does that (build on a merge commit), but if so I’d be surprised they didn’t make the source commit of the PR easy to obtain. :(
s

stocky-spoon-28903

08/25/2018, 8:48 PM
Right - it’s a problem. I’ll figure out what others are doing I guess.
c

colossal-beach-47527

08/25/2018, 8:53 PM
We do link in a Go library that allows us to read the current .git folder, etc. so we might be able to just use the Git APIs available to get that data. (We use that library elsewhere in that same source file until.go IIRC.)
s

stocky-spoon-28903

08/25/2018, 9:20 PM
It looks like it’s possible to get everything needed looking at my test project. I’ll write up what I’ve found as part of the pull request to make it easier to review
👍🏽 1