This message was deleted.

sparse-intern-71089

10/17/2018, 1:00 AM

This message was deleted.

bitter-oil-46081

10/17/2018, 1:02 AM

Yeah, doesn't look like we expose anything that would flow to it. https://github.com/pulumi/pulumi-cloud/blob/master/aws/service.ts#L742-L755 @lemon-spoon-91807 Do you know how we plan to expose the cloud specific options at this layer?

white-balloon-205

10/17/2018, 1:03 AM

Yes - the

healthCheckGracePeriodSeconds

property is not yet exposed in the

cloud.Service

API. And in fact more generally, configuring health checks is not yet exposed through that API. This is part of https://github.com/pulumi/pulumi-cloud/issues/498, I'll add the note on

healthCheckGracePeriodSeconds

specifically. PRs definitely welcome here - but something we'll take a look at soon.

bitter-oil-46081

10/17/2018, 1:03 AM

For context, this is about setting healthCheckGracePeriodSeconds on the service.

full-dress-10026

10/17/2018, 3:00 AM

Is there a workaround for now? Like maybe a way to manually add a value to the service JSON before sending to ECS.

full-dress-10026

10/19/2018, 4:21 PM

Hi. It appears the inability to set

healthCheckGracePeriodSeconds

is causing continuous task restarts. I am interested in investigating submitting a PR to add support for this. I write Clojure at my company, so it has been a long time since I have needed to dive into a TS project. Would one of you be able to provide some guidance as to where to look to start implementing this? Given Terraform supports this operation (https://www.terraform.io/docs/providers/aws/r/ecs_service.html#health_check_grace_period_seconds), I imagine the implementation must be somewhat straightforward. Thanks 🙂

lemon-spoon-91807

10/19/2018, 4:24 PM

Hey Kenny! Let me take a quick look

lemon-spoon-91807

10/19/2018, 4:24 PM

the primary issue is that cloud.Service is a cross platform API.

lemon-spoon-91807

10/19/2018, 4:24 PM

so any changes there need to be figured out for both AWS and Azure.

lemon-spoon-91807

10/19/2018, 4:25 PM

Let me investigate a bit, then i'll report back!

❤️ 1

full-dress-10026

10/19/2018, 4:26 PM

I am actually using the cloud-aws

Service

. Is that also cross platform?

lemon-spoon-91807

10/19/2018, 4:26 PM

the cloud-aws Service is an implementatoin of cloud.Service

lemon-spoon-91807

10/19/2018, 4:26 PM

in general, we've kept these close. but it's potentially possible we could expose cloud-specific customization in a particular layer 🙂

full-dress-10026

10/19/2018, 4:31 PM

Side note: I have seen your response on pulumi-docker #23 and have an item on my list to provide more info. Because that issue is more of an optimization and I have had higher priorities, I haven't been able to get to it yet.

lemon-spoon-91807

10/19/2018, 4:32 PM

no worries 🙂

lemon-spoon-91807

10/19/2018, 4:33 PM

ok. easiest way i can think to support this, for now, would be to just allow a config variable for this

lemon-spoon-91807

10/19/2018, 4:33 PM

because i don't know a clean way to actually add this as part of hte API

lemon-spoon-91807

10/19/2018, 4:33 PM

but you could then have a config variable we'll look for, and which will provide this value.

full-dress-10026

10/19/2018, 4:34 PM

A config var would work!

lemon-spoon-91807

10/19/2018, 4:34 PM

note: our medium term plans here are that this sort of functionality would be exposed directly from a place like pulumi/aws.

full-dress-10026

10/19/2018, 4:35 PM

As part of

Service

lemon-spoon-91807

10/19/2018, 4:35 PM

effectively, we'd have a similar API to pulumi/cloud, except that it would be more AWS specific, and would expose more of the AWS side o things

lemon-spoon-91807

10/19/2018, 4:35 PM

imagine instead of cloud.Service (which needs to work across aws/azre) you'd have something more like:

lemon-spoon-91807

10/19/2018, 4:36 PM

aws.ecs.AwesomeService

lemon-spoon-91807

10/19/2018, 4:36 PM

which would set all this stuff up like what we do in cloud (i.e. setting up the load balancers, task definitions, etc. etc.)

lemon-spoon-91807

10/19/2018, 4:36 PM

except it wouldn't be as abstracted away

full-dress-10026

10/19/2018, 4:37 PM

Makes sense. How come that would be placed in pulumi/aws and not pulumi/cloud-aws?

lemon-spoon-91807

10/19/2018, 4:37 PM

so we could take all the args you might want to override for an AWS ecs service

lemon-spoon-91807

10/19/2018, 4:37 PM

well, "pulumi/cloud" is specifically about hte implementatoins of APIs that are intended to be cross-plat

lemon-spoon-91807

10/19/2018, 4:37 PM

so it kinda goes against that philosophy to them make it plat-specific

lemon-spoon-91807

10/19/2018, 4:37 PM

but we could do it there if ew changed our philosophy a bit 🙂

full-dress-10026

10/19/2018, 4:38 PM

I see. I thought of pulumi/aws as all the low level constructs and pulumi/cloud-aws as abstractions over the lower level stuff.

lemon-spoon-91807

10/19/2018, 4:38 PM

gotcha!

lemon-spoon-91807

10/19/2018, 4:39 PM

we're changing that a bit currently

lemon-spoon-91807

10/19/2018, 4:39 PM

instead of being 'low level', it's more that it's: cloud-specific. so, if you're targetting AWS and want all the power of that, pulumi/aws is a good choice.

lemon-spoon-91807

10/19/2018, 4:39 PM

it's both the real resources you can create, as well as useful cloud-specific abstractions over those resources

lemon-spoon-91807

10/19/2018, 4:40 PM

as opposed to cloud-neutral abstractions

lemon-spoon-91807

10/19/2018, 4:40 PM

note: perhaps doing this at the pulumi/cloud-aws layer also makes sense 🙂

lemon-spoon-91807

10/19/2018, 4:40 PM

we'll definitely consider that, and thanks for sharing your perspective there!

full-dress-10026

10/19/2018, 4:42 PM

Of course! So short term, what is involved in adding a config prop to set

healthCheckGracePeriodSeconds

lemon-spoon-91807

10/19/2018, 4:42 PM

in terms of a PR?

full-dress-10026

10/19/2018, 4:42 PM

Yes

lemon-spoon-91807

10/19/2018, 4:42 PM

it would be really simple

lemon-spoon-91807

10/19/2018, 4:42 PM

i'm going to just check with Luke if this is ok, and then whip it up if so

👍 1

lemon-spoon-91807

10/19/2018, 4:42 PM

i'll see if he has other ideas on the best short term way to unblock you

lemon-spoon-91807

10/19/2018, 4:43 PM

https://github.com/pulumi/pulumi-cloud/blob/b93f873cf1fa451de956b6758f5235a09cd54a7b/aws/service.ts#L21

full-dress-10026

10/19/2018, 4:44 PM

Technically I unblock myself my going to the ECS UI and updating the service manually after running

pulumi update

. But that does not scale, requires my memory to not fail, and is pretty painful 😬

lemon-spoon-91807

10/19/2018, 4:44 PM

That's where we pullin our config values, which can then be used in the file

lemon-spoon-91807

10/19/2018, 4:44 PM

so we'd just add a new value for this, and read it at the appropriate point 🙂

lemon-spoon-91807

10/19/2018, 4:44 PM

from a code level, super simple

lemon-spoon-91807

10/19/2018, 4:44 PM

i just want to make sure i'm not going down a bad path.

full-dress-10026

10/19/2018, 4:45 PM

Right. Let me know if there's anything I can do to help.

lemon-spoon-91807

10/19/2018, 4:52 PM

I'm wrong, you're right 🙂

❓ 1

lemon-spoon-91807

10/19/2018, 4:52 PM

so, we're going to go the route of fixing this up at the cloud-aws layer. i'm going to whip up a quick PR to unblock this. and it will also show the pattern of what we'd generally need to do if more configuration is needed.

lemon-spoon-91807

10/19/2018, 4:53 PM

so if you run into more stuff, you can also open PRs to unblock yourself

full-dress-10026

10/19/2018, 4:54 PM

Sounds great!

lemon-spoon-91807

10/19/2018, 4:55 PM

https://github.com/pulumi/pulumi-cloud/pull/632

full-dress-10026

10/19/2018, 4:57 PM

Woah, that was fast. Super simple. So Pulumi knows to pull and set the value from that prop?

full-dress-10026

10/19/2018, 4:58 PM

Oh I see. Line 756 is where you set it.

lemon-spoon-91807

10/19/2018, 5:29 PM

https://travis-ci.com/pulumi/pulumi-cloud/jobs/153029942

lemon-spoon-91807

10/19/2018, 5:30 PM

once this build is done the code will be available on npm 🙂

full-dress-10026

10/19/2018, 5:30 PM

Awesome. Thank you so much for the speedy work!

Open in Slack

Previous Next

Pulumi Community

No matter how you like to participate in developer communities, Pulumi wants to meet you there. If you want to meet other Pulumi users to share use-cases and best practices, contribute code or documentation, see us at an event, or just tell a story about something cool you did with Pulumi, you are part of our community.