So I m finding myself wedged with the Azure API particularly Pulumi Community #general

Join Slack

So I'm finding myself wedged with the Azure API, p...

# general

boundless-monkey-50243

10/26/2018, 5:50 PM

So I'm finding myself wedged with the Azure API, particularly with regards to app services.

boundless-monkey-50243

10/26/2018, 5:50 PM

I am wondering if Azure changed their API and the downstream Terraform provider hasn't picked it up

boundless-monkey-50243

10/26/2018, 5:51 PM

Or whether Pulumi has an old version of the provider, because the API spec expressed by Terraform here doesn't match my typings: Specifically, looking at this: https://www.terraform.io/docs/providers/azurerm/d/app_service_plan.html#sku

microscopic-florist-22719

10/26/2018, 5:51 PM

cc @luke @stocky-spoon-28903

boundless-monkey-50243

10/26/2018, 5:52 PM

Ack. Rubber duck: that's the bleeping data source, not the component

stocky-spoon-28903

10/26/2018, 5:52 PM

🙂 I do that at least 5 times per day

boundless-monkey-50243

10/26/2018, 5:52 PM

It's actually...still broken

boundless-monkey-50243

10/26/2018, 5:53 PM

The provider does not specify a

SKU.Name

attribute, nor does it accept one when I

as any

my Pulumi code.

boundless-monkey-50243

10/26/2018, 5:53 PM

Copy code

azure:appservice:Plan (edtest-app-service-plan-apps):
    error: Plan apply failed: Error creating/updating App Service Plan "edtest-app-service-plan-apps" (Resource Group "edtest"): web.AppServicePlansClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="The parameter SKU.Name has an invalid value." Details=[{"Message":"The parameter SKU.Name has an invalid value."},{"Code":"BadRequest"},{"ErrorEntity":{"Code":"BadRequest","Message":"The parameter SKU.Name has an invalid value.","MessageTemplate":"The parameter {0} has an invalid value.","Parameters":["SKU.Name"]}}]

boundless-monkey-50243

10/26/2018, 5:53 PM

I then forcibly add one, and:

boundless-monkey-50243

10/26/2018, 5:53 PM

Copy code

azure:appservice:Plan (edtest-app-service-plan-apps):
    error: azure:appservice/plan:Plan resource 'edtest-app-service-plan-apps' has a problem: sku.0: invalid or unknown key: name

stocky-spoon-28903

10/26/2018, 5:55 PM

Hmm let me take a look at it

boundless-monkey-50243

10/26/2018, 5:55 PM

Immediately I'm going "oh hey, version hell", but I don't know where I'd prod between Pulumi and Terraform

stocky-spoon-28903

10/26/2018, 5:56 PM

I don’t see

sku.Name

listed on the terraform docs: https://www.terraform.io/docs/providers/azurerm/r/app_service_plan.html#sku

stocky-spoon-28903

10/26/2018, 5:56 PM

Taking a look at the code

boundless-monkey-50243

10/26/2018, 5:56 PM

Agreed

boundless-monkey-50243

10/26/2018, 5:57 PM

The Azure CLI very much wants an SKU provided by name (which is awful, but at this point I'm almost used to it)

stocky-spoon-28903

10/26/2018, 5:57 PM

Yes, that’s the issue: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_app_service_plan.go#L52-L73

boundless-monkey-50243

10/26/2018, 5:58 PM

Yeah - just got there.

boundless-monkey-50243

10/26/2018, 5:58 PM

Now I legit wonder how this ever worked.

stocky-spoon-28903

10/26/2018, 6:00 PM

Looks like the upstream Azure SDK has it: https://github.com/Azure/azure-sdk-for-go/blob/master/services/web/mgmt/2018-02-01/web/models.go#L17475-L17492

stocky-spoon-28903

10/26/2018, 6:00 PM

So this is something missing from Terraform

stocky-spoon-28903

10/26/2018, 6:00 PM

I’m somewhat surprised that you can provision with Terraform and don’t hit the same error?

boundless-monkey-50243

10/26/2018, 6:05 PM

I think Terraform is generating it.

boundless-monkey-50243

10/26/2018, 6:05 PM

IIRC they have computed properties now

boundless-monkey-50243

10/26/2018, 6:06 PM

Not seeing anywhere it'd be happening though

boundless-monkey-50243

10/26/2018, 6:20 PM

Anybody from Pulumi proper maybe have any idea how this would be manifesting?

stocky-spoon-28903

10/26/2018, 6:36 PM

It would still be considered a bug in Terraform if it was generating values that weren’t in the schema that have some semantic value

stocky-spoon-28903

10/26/2018, 6:38 PM

Hah, here we go: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_app_service_plan.go#L239

stocky-spoon-28903

10/26/2018, 6:38 PM

So, it sets it to be the size

stocky-spoon-28903

10/26/2018, 6:39 PM

Right now, Pulumi should be doing the same thing

boundless-monkey-50243

10/26/2018, 6:39 PM

This is inscrutable. Yikes

stocky-spoon-28903

10/26/2018, 6:41 PM

That’s particularly bizaare behaviour on the part of Terraform - IMO if it is going to do that it also needs to expose the Name as a computed property on the SKU

boundless-monkey-50243

10/26/2018, 6:49 PM

I would think so

boundless-monkey-50243

10/26/2018, 6:49 PM

There are other places where they don't do this

boundless-monkey-50243

10/26/2018, 6:49 PM

If you set up a MySQL server you have to provide all of those and write the name as a string yourself

stocky-spoon-28903

10/26/2018, 6:55 PM

My guess is it was an attempt to simplify

stocky-spoon-28903

10/26/2018, 6:55 PM

opens
git blame
and hopes it wasn’t me…

white-balloon-205

10/26/2018, 7:29 PM

@boundless-monkey-50243 curious - which SKU settings are you ultimately trying to use?

white-balloon-205

10/26/2018, 7:30 PM

My recollection was that there are esoteric (and mostly undocumented by Azure) mappings between these such that’s it is possible to request them via the options TF exposed here.

white-balloon-205

10/26/2018, 7:32 PM

Also cc @tall-librarian-49374 who I know has worked a lot with App Service both with and outside of Pulumi.

boundless-monkey-50243

10/26/2018, 7:50 PM

@white-balloon-205 At the moment, just small/basic/1. Nothing crazy at all, should be supported.

boundless-monkey-50243

10/26/2018, 7:52 PM

Is there some way to get verbose output that would show me what

SKU.Name

actually is?

boundless-monkey-50243

10/26/2018, 7:52 PM

The Pulumi

--verbose

flag is, er, not verbose.

boundless-monkey-50243

10/26/2018, 7:57 PM

No combination I've been able to come up with actually does anything.

tall-librarian-49374

10/26/2018, 7:58 PM

Normal App Service SKU is usually nothing crazy

sku: {    tier: "Basic",  size: "B1", }

. Function App looks a bit wild

sku: { tier: "Dynamic", size: "Y1", }

. Name was never in any of my code...

boundless-monkey-50243

10/26/2018, 7:59 PM

...well, dammit. PEBKAC. Well, sort of.

boundless-monkey-50243

10/26/2018, 7:59 PM

The documentation called the sizes small/medium/large, I thought the SKUs were based off tier+"size"

boundless-monkey-50243

10/26/2018, 7:59 PM

(because nothing I have found in Azure is consistent, I assumed I was just doing something else that was inconsistent)

boundless-monkey-50243

10/26/2018, 8:00 PM

And that was it. Thanks, @tall-librarian-49374 - I appreciate it.

boundless-monkey-50243

10/26/2018, 8:01 PM

(You read the documentation, it talks about tiers and small/medium/large, and...bleh.)

tall-librarian-49374

10/26/2018, 8:03 PM

You are welcome. You can also have a look at a bigger example here: https://github.com/pulumi/examples/blob/master/azure-ts-appservice/index.ts

boundless-monkey-50243

10/26/2018, 8:03 PM

Whoa, didn't even see an example in there for app services

boundless-monkey-50243

10/26/2018, 8:03 PM

Thank you

tall-librarian-49374

10/26/2018, 8:04 PM

Somebody 🙂 even wrote a blog post: https://mikhail.io/2018/06/programmable-cloud-provisioning-azure-app-service-with-pulumi/

26 Views

Open in Slack

Previous Next