When I try to build the latest master version, I'm getting a couple of errors when running

make

gometalinter: error: unknown linters: gas

I think Gometalinter replaced gas with gosec. I delete the

gas

line in

Gometalinter.json

gometalinter --config=../../Gometalinter.json cmd/pulumi-language-nodejs/main.go | sort ; exit "${PIPESTATUS[0]}"
WARNING: deadline exceeded by linter varcheck (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck (try increasing --deadline)
WARNING: deadline exceeded by linter megacheck (try increasing --deadline)
WARNING: deadline exceeded by linter structcheck (try increasing --deadline)
WARNING: deadline exceeded by linter interfacer (try increasing --deadline)
Makefile:19: recipe for target 'lint' failed
make[1]: *** [lint] Error 2
make[1]: Leaving directory '/go/src/github.com/pulumi/pulumi/sdk/nodejs'
build/common.mk:189: recipe for target 'sdk/nodejs_default' failed
make: *** [sdk/nodejs_default] Error 2

Then I delete everything in the Enable section, and then I get the following error:

TEST FAST:
go test -cover -parallel 10 <http://github.com/pulumi/pulumi/sdk/go/pulumi|github.com/pulumi/pulumi/sdk/go/pulumi> <http://github.com/pulumi/pulumi/sdk/go/pulumi/asset|github.com/pulumi/pulumi/sdk/go/pulumi/asset> <http://github.com/pulumi/pulumi/sdk/go/pulumi/config|github.com/pulumi/pulumi/sdk/go/pulumi/config> <http://github.com/pulumi/pulumi/sdk/go/pulumi-language-go|github.com/pulumi/pulumi/sdk/go/pulumi-language-go>
# <http://github.com/pulumi/pulumi/sdk/go/pulumi-language-go|github.com/pulumi/pulumi/sdk/go/pulumi-language-go>
pulumi-language-go/main.go:107: Verbose.Infoln call has possible formatting directive %s
pulumi-language-go/main.go:115: Verbose.Infoln call has possible formatting directive %s
pulumi-language-go/main.go:122: Verbose.Infoln call has possible formatting directive %s
pulumi-language-go/main.go:145: Verbose.Infoln call has possible formatting directive %s
ok    <http://github.com/pulumi/pulumi/sdk/go/pulumi|github.com/pulumi/pulumi/sdk/go/pulumi>  0.005s  coverage: 17.7% of statements
?     <http://github.com/pulumi/pulumi/sdk/go/pulumi/asset|github.com/pulumi/pulumi/sdk/go/pulumi/asset>  [no test files]
ok    <http://github.com/pulumi/pulumi/sdk/go/pulumi/config|github.com/pulumi/pulumi/sdk/go/pulumi/config> 0.005s  coverage: 26.6% of statements
Makefile:26: recipe for target 'test_fast' failed
make[1]: *** [test_fast] Error 2
make[1]: Leaving directory '/go/src/github.com/pulumi/pulumi/sdk/go'
build/common.mk:189: recipe for target 'sdk/go_default' failed
make: *** [sdk/go_default] Error 2

We use specific versions of many dependent tools, including gometalinter. See https://github.com/pulumi/pulumi/blob/master/build/tool-versions.sh. Looks like the instructions in the readme may not be up to date with some breaking changes in more recent versions of those tools.

I noticed this just recently. Let's file an issue and upgrade this soon, since the old installation technique we are using seems to be deprecated. I also thought we would need to do this upgrade as part of moving to Go 1.11, but I guess not? @stocky-spoon-28903 did you run into any troubles here also?

https://github.com/pulumi/home/issues/376 is tracking this.

We need to update it for go 1.11, but we may as well switch to GolangCI-lint which is less resource hungry and a bit faster

Thanks, for now I've worked around the build failure by commenting out the

logging.V(5).Infoln

lines in

pulumi/pulumi/sdk/go/pulumi-language-go/main.go