https://pulumi.com
Join Slack
This message was deleted.
# general
s
This message was deleted.
f
Oh, and 
PULUMI_CI_SYSTEM == "Buildkite"
as well
bumping this since it’s now monday
w
cc @colossal-beach-47527 and @clever-sunset-76585 in case they know.
c
Hi @fierce-dinner-20116 there are a few more values required needed so the the Pulumi GitHub app can comment on your PRs. Let me dig up the right values…
👍 1
The Pulumi GitHub app works by recognizing the Git commit SHA in the update(s) performed on your CI system, and then matching those to the git commit SHAs from your pull request. So the values we need are here: https://github.com/pulumi/pulumi/blob/master/cmd/util.go#L501 
PULUMI_CI_PULL_REQUEST_SHA
- The commit hash of the pull request. This is usually different from what is being built on your CI system, since your CI system builds at the merge commit of the pull request merged into the target branch.
We haven’t added automatic detection for BuildKite. But if you are feeling saucy, you are more than welcome to add it. Just take a look at the files in this directory: https://github.com/pulumi/pulumi/tree/master/pkg/util/ciutil. It should just be a matter of adding the right environment variables that are sent on the BuildKite builder. e.g. a BuildKite part of this switch statement: https://github.com/pulumi/pulumi/blob/master/pkg/util/ciutil/vars.go#L53
Let me know if that works out for you, or if you have any other questions.
f
Thanks, it worked! I’ll look into submitting a PR to add proper Buildkite support. Thanks for your help!
🙌🏽 2
Open in Slack
PreviousNext
Powered by

Pulumi Community

No matter how you like to participate in developer communities, Pulumi wants to meet you there. If you want to meet other Pulumi users to share use-cases and best practices, contribute code or documentation, see us at an event, or just tell a story about something cool you did with Pulumi, you are part of our community.

Powered by