https://pulumi.com logo
Powered by
f

fresh-summer-65887

07/05/2019, 9:11 AM
(AWS) Updating packages and get a compilation error and what is looking like a documentation bug regarding DNS validation for certificates https://www.pulumi.com/docs/reference/pkg/nodejs/pulumi/aws/acm/#dns-validation-with-route-53
package.json before:
Copy code
{
  "name": "aws-typescript",
  "devDependencies": {
    "@types/node": "^12.0.8"
  },
  "dependencies": {
    "@pulumi/aws": "^0.18.8",
    "@pulumi/awsx": "^0.18.5",
    "@pulumi/pulumi": "^0.17.17"
  }
}
package.json after:
Copy code
{
  "name": "aws-typescript",
  "devDependencies": {
    "@types/node": "^12.0.12"
  },
  "dependencies": {
    "@pulumi/aws": "^0.18.16",
    "@pulumi/awsx": "^0.18.6",
    "@pulumi/pulumi": "^0.17.21"
  }
}
Compilation error is related to : 
type: certCertificate.domainValidationOptions[0].resourceRecordType,
b

broad-dog-22463

07/05/2019, 9:13 AM
<ignore that>
f

fresh-summer-65887

07/05/2019, 9:14 AM
b

broad-dog-22463

07/05/2019, 9:15 AM
yeah i need to fix this up
f

fresh-summer-65887

07/05/2019, 9:15 AM
Looks like 
RecordArgs.Type
changed to 
Input<RecordType>
b

broad-dog-22463

07/05/2019, 9:15 AM
correct
f

fresh-summer-65887

07/05/2019, 9:15 AM
bah, didn't find that when I searched github
b

broad-dog-22463

07/05/2019, 9:15 AM
I will make a change in a sec that fixes you up
we should allow either or
let me open a PR now
one sec
f

fresh-summer-65887

07/05/2019, 9:16 AM
b

broad-dog-22463

07/05/2019, 9:17 AM
it does
that is what I am doing now
I will tag you on this PR
👍 1
f

fresh-summer-65887

07/05/2019, 9:17 AM
Best course of action for now? downgrade?
b

broad-dog-22463

07/05/2019, 9:18 AM
let me find the version it changed
0.18.9 should fix this up for you
f

fresh-summer-65887

07/05/2019, 9:19 AM
cheers mate
b

broad-dog-22463

07/05/2019, 9:23 AM
let me know if that fixes it
I will try and make a hot fix for this
f

fresh-summer-65887

07/05/2019, 9:24 AM
Yeah looks like a serious one that might affect many people if they upgrade (I think).
b

broad-dog-22463

07/05/2019, 9:27 AM
f

fresh-summer-65887

07/05/2019, 9:31 AM
subscribed
b

broad-dog-22463

07/05/2019, 10:48 AM
@fresh-summer-65887 your release is being prepared now
will take about 30 mins for the cycle of tests
f

fresh-summer-65887

07/05/2019, 10:48 AM
deadly
b

broad-dog-22463

07/05/2019, 11:25 AM
@fresh-summer-65887 your release is out 😉
let me know if this fixes your error please
Powered by