(AWS) Updating packages and get a compilation erro...
# generalf
fresh-summer-65887
07/05/2019, 9:11 AM(AWS) Updating packages and get a compilation error and what is looking like a documentation bug regarding DNS validation for certificates https://www.pulumi.com/docs/reference/pkg/nodejs/pulumi/aws/acm/#dns-validation-with-route-53
fresh-summer-65887
07/05/2019, 9:12 AMpackage.json before:
Copy code
{
"name": "aws-typescript",
"devDependencies": {
"@types/node": "^12.0.8"
},
"dependencies": {
"@pulumi/aws": "^0.18.8",
"@pulumi/awsx": "^0.18.5",
"@pulumi/pulumi": "^0.17.17"
}
}fresh-summer-65887
07/05/2019, 9:12 AMpackage.json after:
Copy code
{
"name": "aws-typescript",
"devDependencies": {
"@types/node": "^12.0.12"
},
"dependencies": {
"@pulumi/aws": "^0.18.16",
"@pulumi/awsx": "^0.18.6",
"@pulumi/pulumi": "^0.17.21"
}
}fresh-summer-65887
07/05/2019, 9:13 AMCompilation error is related to :
type: certCertificate.domainValidationOptions[0].resourceRecordType,b
broad-dog-22463
07/05/2019, 9:13 AM<ignore that>
f
fresh-summer-65887
07/05/2019, 9:14 AMb
broad-dog-22463
07/05/2019, 9:15 AMyeah i need to fix this up
broad-dog-22463
07/05/2019, 9:15 AMf
fresh-summer-65887
07/05/2019, 9:15 AMLooks like
RecordArgs.TypeInput<RecordType>b
broad-dog-22463
07/05/2019, 9:15 AMcorrect
f
fresh-summer-65887
07/05/2019, 9:15 AMbah, didn't find that when I searched github
b
broad-dog-22463
07/05/2019, 9:15 AMI will make a change in a sec that fixes you up
broad-dog-22463
07/05/2019, 9:15 AMwe should allow either or
broad-dog-22463
07/05/2019, 9:15 AMlet me open a PR now
broad-dog-22463
07/05/2019, 9:15 AMone sec
f
fresh-summer-65887
07/05/2019, 9:16 AMhttps://github.com/pulumi/docs/pull/1243#issuecomment-506525362 <- needs a code fix I think?
b
broad-dog-22463
07/05/2019, 9:17 AMit does
broad-dog-22463
07/05/2019, 9:17 AMthat is what I am doing now
broad-dog-22463
07/05/2019, 9:17 AMI will tag you on this PR
👍 1
f
fresh-summer-65887
07/05/2019, 9:17 AMBest course of action for now? downgrade?
b
broad-dog-22463
07/05/2019, 9:18 AMlet me find the version it changed
broad-dog-22463
07/05/2019, 9:19 AM0.18.9 should fix this up for you
f
fresh-summer-65887
07/05/2019, 9:19 AMcheers mate
b
broad-dog-22463
07/05/2019, 9:23 AMlet me know if that fixes it
broad-dog-22463
07/05/2019, 9:23 AMI will try and make a hot fix for this
f
fresh-summer-65887
07/05/2019, 9:24 AMYeah looks like a serious one that might affect many people if they upgrade (I think).
b
broad-dog-22463
07/05/2019, 9:27 AMf
fresh-summer-65887
07/05/2019, 9:31 AMsubscribed
b
broad-dog-22463
07/05/2019, 10:48 AM@fresh-summer-65887 your release is being prepared now
broad-dog-22463
07/05/2019, 10:48 AMwill take about 30 mins for the cycle of tests
f
fresh-summer-65887
07/05/2019, 10:48 AMdeadly
b
broad-dog-22463
07/05/2019, 11:25 AM@fresh-summer-65887 your release is out 😉
broad-dog-22463
07/05/2019, 11:25 AMlet me know if this fixes your error please