did 1.2.0 break upgrading via helm again? (e.g. upgrading the nginx ingress controller)

@bitter-dentist-28132 not that we know of. do you have more details to share? also, when did it break before?

see #796, 793. now when trying to upgrade the chart, it says

deployments.apps "nginxingresscontroller-nginx-ingress-controller" already exists

@bitter-dentist-28132 let me see if I can reproduce the issue, though I would note that those aren’t helm-specific, and this one might not be either.

just adding it generically

const nginxIngressController = new k8s.helm.v2.Chart('nginxingresscontroller', {
        chart: 'nginx-ingress',
        namespace: 'default',
        repo: 'stable',
        values: {
            controller: {
                metrics: {
                    service: {
                        omitClusterIP: true,
                    },
                },
                service: {
                    omitClusterIP: true,
                },
            },
            defaultBackend: {
                service: {
                    omitClusterIP: true,
                },
            },
        },
    }, {
        providers: {
            kubernetes: provider,
        },
    });

in the values?

sorry, what i meant is that it's usually only

metadata.labels.chart

that changes for the k8s objects, since most of the chart dev doesn't affect "standard" deployments. though it seems this time it's doing a full destroy/create of the deployments.

do you know what you changed to instigate this?

upgrading the chart version. looks like the first one that failed was

"nginx-ingress-1.21.0" => "nginx-ingress-1.23.0"

trying now

looks like that changed to the new

apiVersion

for deployments

oh

i guess pulumi won't order things properly for that kind of operation?

we have a PR in flight for this, but it will take some time to land:

if the delete is done before the create, that shouldn't matter though, yes? i guess all deletes are done after all creates?

if you don’t specify a

.metadata.name

then yes

yes indeed. or pin.

Anyway, apologies—I’ll try to get a fix in over the next day. I need to verify this works for all corner cases though.

that's ok, i do feel like simply saying old === new could cause problems so i can see why you'd be hesitant to just accept it.