https://pulumi.com logo
Powered by
c

cool-egg-852

10/02/2019, 5:02 PM
Is there any information on when the kubernetes provider 1.2 version will be released? Asking because we’re running into an issue with the hack done for waiting on jobs, and it would be cool to not need to fix the hack further.
Also how do we use it if we install from master?
w

worried-city-86458

10/02/2019, 5:31 PM
I had to switch to 
yarn
instead of 
npm
then update 
packages.json
to refer to 
alpha
versions; e.g. for 
@pulumi/pulumi
package:
Copy code
{
  "name": "aws-typescript",
  "devDependencies": {
    "@types/node": "^8.0.0"
  },
  "dependencies": {
    "@pulumi/kubernetes": "^1.0.0",
    "@pulumi/pulumi": "^1.3.0-alpha",
    "@types/nodecredstash": "^2.0.0",
    "nodecredstash": "^2.0.2"
  },
  "resolutions": {
    "**/@pulumi/pulumi": "^1.3.0-alpha"
  }
}
I'm sure it would be the same for 
@pulumi/kubernetes
c

cool-egg-852

10/02/2019, 5:31 PM
We use yarn ourselves too.
Thanks for the info, I was using 
@dev
but 
^1.2.0-alpha
looks like it should work too
Now I just need to understand how to use this feature
Unfortunately the PR https://github.com/pulumi/pulumi-kubernetes/pull/633 did not provide detaisl on it
w

worried-city-86458

10/02/2019, 5:32 PM
Yeah I couldn't get 
@dev
to work with yarn resolutions
c

cool-egg-852

10/02/2019, 5:33 PM
@gorgeous-egg-16927 Since you wrote the code, maybe you can assist. I am also confused as to how to configure how long Pulumi waits for the job to complete.
c

creamy-potato-29402

10/02/2019, 5:36 PM
@cool-egg-852 @worried-city-86458 we’ll probably release tomorrow, I’m guessing?
@gorgeous-egg-16927 is out until tomorrow
c

cool-egg-852

10/02/2019, 5:36 PM
Ah
Do you have any idea how to make use of the change?
c

creamy-potato-29402

10/02/2019, 5:37 PM
Job
?
it should work just like any other resource.
new Job
will cause a “normal” experience where we wait for it to complete, as we do with stuff like 
Deployment
c

cool-egg-852

10/02/2019, 5:38 PM
Gotcha. I wasn’t sure if that’s what the feature did or not.
So how do we customize the timeout? For example, I have Job1 and I want it to wait up to an hour for it to complete. Given that 
creating
a job only takes a few seconds, I’m not sure if the 
create
in 
customTimeouts
is considered as part of this await logic.
c

creamy-potato-29402

10/02/2019, 5:39 PM
it works the same as customizing any other timeout
but we will actually wait for the job to complete by default
c

cool-egg-852

10/02/2019, 5:39 PM
So 
create
now takes into consideration the completion of the job, not just how long it takes to create?
I’m referring to 
customTimeouts: {create: ''}
c

creamy-potato-29402

10/02/2019, 5:40 PM
yeah
c

cool-egg-852

10/02/2019, 5:40 PM
Ok cool. I don’t have an easy way to test this out, which is why I was asking.
c

creamy-potato-29402

10/02/2019, 5:40 PM
Yeah, I think you can, you can 
skip-await
too
if you put in 
dev
in package.json it should “just work”
c

cool-egg-852

10/02/2019, 5:41 PM
I used 
^1.2.0-alpha
and it worked just fine. Thanks for all the assistance.
c

creamy-potato-29402

10/02/2019, 5:41 PM
np
#itsmyjob
c

cool-egg-852

10/02/2019, 5:41 PM
I understand that documentation is automatically done, I think the problem here was the lack of documentation for anyone who knew how it worked prior to the PR.
c

creamy-potato-29402

10/02/2019, 5:41 PM
my 
Job
, if you’ll permit my one dad joke for the day
c

cool-egg-852

10/02/2019, 5:42 PM
I think having documentation for those scenarios is a must.
LOL
c

creamy-potato-29402

10/02/2019, 5:42 PM
you mean, for the await logic?
c

cool-egg-852

10/02/2019, 5:42 PM
For anytime something is done different than previously.
c

creamy-potato-29402

10/02/2019, 5:42 PM
the hope was that if we added support the experience would simply get better
c

cool-egg-852

10/02/2019, 5:42 PM
In this case yes, the await logic.
c

creamy-potato-29402

10/02/2019, 5:42 PM
I’m guessing we’ll write a blog post about it
c

cool-egg-852

10/02/2019, 5:43 PM
Because anyone who knew how it worked before will be confused as I was.
As the PR mentions 0 ways in how to use the new feature
c

creamy-potato-29402

10/02/2019, 6:01 PM
The PR is scoped mainly to implementation
You are right we should communicate this stuff better
maybe PR is the right place
c

cool-egg-852

10/02/2019, 6:03 PM
Given it’s linked to in the CHANGELOG.md file, it’s where I would expect some information.
c

creamy-potato-29402

10/02/2019, 6:09 PM
makes sense
thanks for the feedback, and cc @gorgeous-egg-16927
Powered by