This message was deleted.
s
This message was deleted.
c
Also it would be nice if stuff like helm, gcloud, aws, etc. could be bundled in a pre-made image.
A language specific image doesn’t make sense to exclude the tools in the primary image. It’s not just language specific then.
b
Hi @cool-egg-852 Thanks for pointing out the missing code - we will get that fixed up today! The main Pulumi image has all of those dependencies
c
I’m aware it does, but it also has every language SDK
Language specific image != slim image
The expectation with these was to remove other languages, not all the tools.
Just because I only need node doesn’t mean I don’t need gcloud, helm, etc.
b
I'm not sure where that expectation was - I didn't ever realise that was the case
We can always open an issue and look at including these
c
The name describes the expectation. Everyone asked for language specific images so we wouldn’t have Go, .net, python, etc. included. I’m not aware of people asking to have nothing but pulumi itself included.
b
We did actually use a combination of all of the issues around this - there was actually an ask for containers without the Pulumi entrypoint so people could build on top of them
c
Also, another issue, the
Usage
in the README says that there is no CMD, but the
Dockerfile
does have
CMD
set. Not sure which is correct.
b
the README is incorrect - I will get that fixed up
c
https://github.com/pulumi/pulumi/issues/3789 - which is at least one ticket that asked for this never requests to remove all the extra functionality.
The literal goal was to have one image per SDK, but with all the features it has today based on the request.
Everyone shouldn’t have to maintain their own docker image for using pulumi in a reasonable manner IMO
Having
pulumi/pulumi:nodejs
,
pulumi/pulumi:nodejs-slim
makes a lot more sense to me.
pulumi/pulumi:nodejs
then becomes the same as the main image, but with only
nodejs
, not .net and python and such. And the
-slim
variant is what you have currently built.
b
so we can easily do this and publish these as well - it's just a matrix of GHA
c
That would be awesome.
b
Feel free to add any more information you feel would help here
Oh @cool-egg-852 - you said, "missing the example for installing helm" - I don't follow on that one - can you link me to what is missing?
c
The last sentence there.
There is no actual example of installing Helm in docker
And I commented on the issue with a use case in case that assists with planning.
b
got it
b
@cool-egg-852 thanks for the feedback, looks like I forgot to push the commit with the changes showing the example Dockerfile, I'll do that now Looks like I also added a
CMD
erroneously, I'll get that fixed up I'll respond to the comment about the extra tooling in the GitHub issue