This message was deleted.
# general
s
This message was deleted.
c
There should not be breaking changes in non major versions, but then if there is, and we deal with it, we don’t expect a bugfix release to undo all of it.
Especially with no mention in the
CHANGELOG.md
. All that was said is
upgraded terraform provider
cc @gentle-diamond-70147
b
@cool-egg-852 this actually happened upstream and wasn't called out in their CHANGELOG so it was my bad for not studying the changes enough
I am sorry about this
this is something we are not aware of and are writing internal guidelines on when a major version needs to happen
w
Just to add - it is definitely our policy that a breaking change would be in a major version bump and would be called out clearly in a CHANGELOG. In this case, a dependency of ours made an unintentional semver-incompatible breaking change without notice. This was a bug in the dependency's release process which we also unfortunately bled through to our users when we updated to the latest version of that dependency. We will be reviewing our processes around more deeply validating dependencies especially for the most heavily used Pulumi providers.
c
Thanks, though in this case my issue is more on the revert than the original issue.
I had already updated our code, but then with the change today, I had to revert all of that.
I’m not sure if both the original breaking change and the revert was unknown or not based on your messages.
If so, I get it, if not, then at least the revert should have been noted.
But also, the changelog specified
upgrade
when it wasn’t, it was a revert to 2.9.0 from 2.10.0. So the changelog needs some work .
w
if not, then at least the revert should have been note
That's a very good point - we absolutely should have (and should now) noted the breaking change revert in the CHANGELOG. We'll update that now.
c
Thanks!
b
As I said, completely my fail here @cool-egg-852 - apologise for not picking up this was the case :/
c
No problem. Live and learn 🙂