This message was deleted.
# generals
sparse-intern-71089
07/09/2020, 6:47 PMThis message was deleted.
c
cool-egg-852
07/09/2020, 6:52 PMThere should not be breaking changes in non major versions, but then if there is, and we deal with it, we don’t expect a bugfix release to undo all of it.
cool-egg-852
07/09/2020, 6:53 PMEspecially with no mention in the
CHANGELOG.mdupgraded terraform providercool-egg-852
07/09/2020, 6:58 PMcc @gentle-diamond-70147
b
broad-dog-22463
07/09/2020, 7:38 PM@cool-egg-852 this actually happened upstream and wasn't called out in their CHANGELOG so it was my bad for not studying the changes enough
broad-dog-22463
07/09/2020, 7:38 PMI am sorry about this
broad-dog-22463
07/09/2020, 7:38 PMbroad-dog-22463
07/09/2020, 7:38 PMthis is something we are not aware of and are writing internal guidelines on when a major version needs to happen
w
white-balloon-205
07/09/2020, 7:42 PM
Just to add - it is definitely our policy that a breaking change would be in a major version bump and would be called out clearly in a CHANGELOG.
In this case, a dependency of ours made an unintentional semver-incompatible breaking change without notice. This was a bug in the dependency's release process which we also unfortunately bled through to our users when we updated to the latest version of that dependency. We will be reviewing our processes around more deeply validating dependencies especially for the most heavily used Pulumi providers.
c
cool-egg-852
07/09/2020, 7:43 PMThanks, though in this case my issue is more on the revert than the original issue.
cool-egg-852
07/09/2020, 7:43 PMI had already updated our code, but then with the change today, I had to revert all of that.
cool-egg-852
07/09/2020, 7:44 PMI’m not sure if both the original breaking change and the revert was unknown or not based on your messages.
cool-egg-852
07/09/2020, 7:44 PMIf so, I get it, if not, then at least the revert should have been noted.
cool-egg-852
07/09/2020, 7:44 PMBut also, the changelog specified
upgradew
white-balloon-205
07/09/2020, 7:47 PM
if not, then at least the revert should have been noteThat's a very good point - we absolutely should have (and should now) noted the breaking change revert in the CHANGELOG. We'll update that now.
c
cool-egg-852
07/09/2020, 7:53 PMThanks!
b
broad-dog-22463
07/09/2020, 8:23 PMAs I said, completely my fail here @cool-egg-852 - apologise for not picking up this was the case :/
c
cool-egg-852
07/09/2020, 8:29 PMNo problem. Live and learn 🙂