https://pulumi.com logo
#general
Title
# general
l

lemon-lighter-66078

12/09/2021, 8:23 PM
Hi all! I'm setting up pulumi with github actions, I installed the pulumi github app but I cannot see any comments on the PR that triggers the workflow nor the checks integration. Any ideas?
e

elegant-window-55250

12/09/2021, 8:27 PM
👋 Did you follow this guide? https://github.com/pulumi/actions In that case, there shouldn't be a need for the Pulumi Github App. Just make sure to set
comment-on-pr
to
true
🙂
l

lemon-lighter-66078

12/09/2021, 8:32 PM
I followed the guide and got github actions to make the comment. But I wanted to use the app since it looks a bit nicer
The github app was installed, but it just seems to do nothing? This is not the expected behaviour
e

elegant-window-55250

12/09/2021, 8:38 PM
Not sure if it works any longer, since the new Github Actions is using Pulumi Automation API. I like the feedback about it looking nicer, which part do you think we can improve on?
d

dry-army-62560

12/10/2021, 12:52 AM
I also installed the Pulumi GitHub App and didn't get it working. The comment-on-pr works, but I thought the GitHub App seemed to look a little bit nicer and integrated (using the checks api sounds better than just the PR comment)
e

early-intern-90238

12/10/2021, 1:53 AM
I made a fork of it a while back if you have any questions.
l

lemon-lighter-66078

12/10/2021, 8:21 AM
If the github app doesn't work it should surely be removed from the official documentation?
@elegant-window-55250 I think the pulumi logo on pulumi comments looks nice and make sure it doesn't get lost in the other github actions comments on a PR (SonarQube etc.) The integration with the checks API also makes it stand out compared to just using the github actions comment
e

elegant-window-55250

12/10/2021, 8:29 AM
Nice, I can open an issue to see if we could improve on that. How would you like Checks API to work? I dream of using annotations to give errors/output on the line number of the resource. I can post the issue here when I create it, maybe you could leave you thoughts there? 🙂
🙌 1
l

lemon-lighter-66078

12/10/2021, 8:34 AM
I suggest removing the github app from docs until it works. This makes it seem that the github app is the default and preferred method, even though it doesn't work. I LOVE your idea, that is the dream indeed. I'll follow the issue closely
👍 1
e

elegant-window-55250

12/10/2021, 8:38 AM