Can this code be simplified?

foreach (var element in Environment.GetEnvironmentVariables())
{
    if (element is KeyValuePair<string, object> pair
        && pair.Value is string valueStr)
        env[pair.Key] = valueStr;
}

Environment.GetEnvironmentVariables

returns an

IDictionary

. Ideally, it would be typed, but generics probably hadn't been introduced yet. I think it's obvious that it should actually return

IDictionary<string, string?>

, but in case of any doubt

Environment.GetEnvironmentVariable(string)

only returns

string?

, not

object

. So what value does

element is KeyValuePair<string, object>

give us? Therefore, couldn't the code be simplified to

foreach (var pair in Environment.GetEnvironmentVariables())
{
    if (pair.Value is string valueStr)
        env[pair.Key] = valueStr;
}

@bored-oyster-3147

Maybe? But I don't know if we know the type of

pair.Key

is

string

at compile-time so

env[pair.key] = ...;

might give you an error?

Ah, that makes sense. There's no problems, I was just confused why the second type was

object

and not

string

.

Have you personally tried passing environment variables from your system into pulumi? I was just messing with this code in a console app and I found some issues (thanks for bringing it up, lol). First of all,

element

is of type

System.Collection.DictionaryEntry?

. And none of them satisfied

KeyValuePair<string, object>

,

KeyValuePair<string, string>

, or

KeyValuePair<string, string?>

... which is concerning I actually had to do this to get working:

var env = Environment.GetEnvironmentVariables();
            foreach (DictionaryEntry? element in env)
            {
                if (element is null || !element.HasValue)
                    continue;

                if (element.Value.Key is string keyStr
                    && element.Value.Value != null
                    && element.Value.Value is string valueStr)
                    Console.WriteLine($"[{keyStr}] = {valueStr}");
            }

https://docs.microsoft.com/en-us/dotnet/api/system.environment.getenvironmentvariables?view=net-5.0 for more details on

System.GetEnvironmentVariables

that's a pretty big faux pas on my part yikes

This is redundant:

element.Value.Value != null
                    && element.Value.Value is string valueStr

you are correct, that is because I was doing this first and was getting an error and switched to what I posted

if (element.Value.Key is string keyString
                    && element.Value.Value is string valueString)
                {
                    env[keyString] = valueString;
                }

Should work (with the element null check)

Hey team just seeing this discussion here 👋

Cool so we should be good with your PR, then. Awesome.

Yeah, deleted code is best code!