https://pulumi.com logo
#contribute
Title
# contribute
b

bored-river-53178

06/17/2019, 3:35 PM
Hello, I am trying to build pulumi (using https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) and facing errors in the process. Is that the right channel for help?
t

tall-librarian-49374

06/17/2019, 3:41 PM
yes!
b

bored-river-53178

06/17/2019, 4:09 PM
ok, so the first error is from Golangci-lint:
cmd/pulumi-language-nodejs/main.go8756:
langauge
is a misspelling of
language
(misspell) cmdutil.InitTracing("pulumi-language-nodejs", "pulumi-langauge-nodejs", tracing)
and that's kinda strange
surely all the others trying build pulumi with the same process should face the same error?
but git blame shows that the line is more than one year old
but that one is harmless, after fixing the type I face another error:
# github.com/cpuguy83/go-md2man/md2man ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1116: undefined: blackfriday.EXTENSION_NO_INTRA_EMPHASIS ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1216: undefined: blackfriday.EXTENSION_TABLES ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1316: undefined: blackfriday.EXTENSION_FENCED_CODE ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1416: undefined: blackfriday.EXTENSION_AUTOLINK ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1516: undefined: blackfriday.EXTENSION_SPACE_HEADERS ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1616: undefined: blackfriday.EXTENSION_FOOTNOTES ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1716: undefined: blackfriday.EXTENSION_TITLEBLOCK ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/md2man.go1929: too many arguments to conversion to blackfriday.Markdown: blackfrida y.Markdown(doc, renderer, extensions) ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/roff.go199: cannot use &roffRenderer literal (type *roffRenderer) as type blackfrid ay.Renderer in return argument: *roffRenderer does not implement blackfriday.Renderer (missing RenderFooter method) ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/roff.go10211: undefined: blackfriday.LIST_TYPE_ORDERED ../../go/pkg/mod/github.com/cpuguy83/go-md2man@v1.0.10/md2man/roff.go10211: too many errors az@eoan ~/git/pulumi $
ok, I solved the second one by putting the sources inside $GO_HOME
still confused about linter errors (there are other ones later in the process) but at least I can build a pulumi binary now
========== Pulumi SDK ========== BUILD: go install -ldflags "-X github.com/pulumi/pulumi/pkg/version.Version=v0.17.18-dev.1560526288+g0b4d94a2.dirty" github.com/pulumi/pulumi INSTALL: GOBIN=/opt/pulumi/bin go install -ldflags "-X github.com/pulumi/pulumi/pkg/version.Version=v0.17.18-dev.1560526288+g0b4d94a2.dirty" github.com/pulumi/pulumi LINT: golangci-lint run pkg/resource/plugin/provider_plugin_test.go10662:
properites
is a misspelling of
properties
(misspell) assert.Truef(t, reflect.DeepEqual(fromVal, val), "expected properites %s to be deeply equal", key) ^ tests/integration/integration_test.go22654:
sould
is a misspelling of
could
(misspell) contract.AssertNoErrorf(err, "resource.NewUniqueHex sould not fail with no maximum length is set") ^ tests/integration/integration_test.go26854:
sould
is a misspelling of
could
(misspell) contract.AssertNoErrorf(err, "resource.NewUniqueHex sould not fail with no maximum length is set") ^ pkg/resource/deploy/step_generator.go3044: S1020: when ok is true, err can't be nil (gosimple) if _, ok := err.(plugin.DiffUnavailableError); ok { ^ make: * [Makefile25 lint] Error 1
w

white-balloon-205

06/17/2019, 4:32 PM
Which version of
golanglint-ci
are you using? It looks like our CI builds `1.16.0`: https://github.com/pulumi/scripts/blob/master/ci/install-common-toolchain.sh#L24
I opened https://github.com/pulumi/pulumi/issues/2835. Feel free to add anything else that needs improving there (and also feel free to send a PR!)
b

bored-river-53178

06/17/2019, 4:36 PM
the latest one, 1.17.1 I'll retry with 1.16.0
thanks!
7 Views