https://pulumi.com logo
#contribute
Title
# contribute
t

thousands-telephone-86052

07/02/2019, 4:15 PM
Hey guys.. wondering why my PR had to be reverted: https://github.com/pulumi/pulumi-eks/pull/190 - @breezy-hamburger-69619 or @white-balloon-205 ?
w

white-balloon-205

07/02/2019, 5:44 PM
t

thousands-telephone-86052

07/03/2019, 12:58 AM
Think I found the issue. I added this call:
Copy code
instanceProfile = aws.iam.InstanceProfile.get(`${name}-instanceProfile`, instanceProfileName, undefined, { parent: parent });
which should not require a role argument, since its only looking up an existing instance profile. But it seems to invoke a "new" on InstanceProfile:
Copy code
66     /**
 67      * Get an existing InstanceProfile resource's state with the given name, ID, and optional extra
 68      * properties used to qualify the lookup.
 69      *
 70      * @param name The _unique_ name of the resulting resource.
 71      * @param id The _unique_ provider ID of the resource to lookup.
 72      * @param state Any extra arguments used during the lookup.
 73      */
 74     static get(name, id, state, opts) {
 75         return new InstanceProfile(name, state, Object.assign({}, opts, { id: id }));
 76     }
ref: https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/iam/instanceProfile.ts#L52
I'll test aws.iam.InstanceProfile.get() in isolation tomorrow.
w

white-balloon-205

07/03/2019, 1:07 AM
If I was to guess, it seems like perhaps
instanceProfileName
is undefined here? That could lead to this error from this line I believe.
t

thousands-telephone-86052

07/03/2019, 4:00 PM
Think I found the issue. Pushed a commit.
looks like the build passed..