https://pulumi.com logo
#contribute
Title
# contribute
b

broad-dog-22463

02/25/2020, 8:22 AM
@limited-rainbow-51650 to circle back to this release - there is no new upstream release yet 😕 Your work is in master - so we will wait for Julien to cut a new release - maybe you can ask him 🙂
l

limited-rainbow-51650

02/25/2020, 8:26 AM
I did: https://github.com/terraform-providers/terraform-provider-gitlab/pull/259#issuecomment-589954013 Meanwhile, I wanted to know if Pulumi could create a release even if there is no TF provider release tagged. If not, is this a process issue or a technical issue?
My contribution started on 15 Jan. I hope you understand I’m a bit impatient by now. 😉
I have the impression that Julien wants to get to the bottom of the test failures first before creating a new TF provider release. But this could still take a while…
b

broad-dog-22463

02/25/2020, 8:30 AM
We can of course cut against master
👏🏼 1
but if there are test failures, then it could be a legit bug
this is my test failure:
Copy code
[ pulumi-gitlab/examples/project ]     error: deleting urn:pulumi:p-it-travis-job-project-a8b35cfc::label-gitlab::gitlab:index/project:Project::example-project: error waiting for project (16618257) to become deleted: timeout while waiting for state to become 'Deleted' (last state: 'Deleting', timeout: 10m0s)
and it is a legit bug in the provider
l

limited-rainbow-51650

02/25/2020, 8:31 AM
It is strange though that I only have an error in the TF tests on deleting a Group. And only a single failure.
b

broad-dog-22463

02/25/2020, 8:31 AM
I started seeing this error when I saw GitLab changed their API
l

limited-rainbow-51650

02/25/2020, 8:34 AM
Where in the release notes can I identify the changes to the API? https://about.gitlab.com/releases/
b

broad-dog-22463

02/25/2020, 8:36 AM
I just remember them changing the limits
I am running a test of this project and it's been "deleting" for 7 mins
@limited-rainbow-51650 I think this might be the issue with delete
it actually does the delete later 😕 Not instantly
l

limited-rainbow-51650

02/25/2020, 8:46 AM
Hmm… same is introduced for Groups in the latest Gitlab 12.8 https://docs.gitlab.com/ee/api/groups.html#remove-group
b

broad-dog-22463

02/25/2020, 8:49 AM
this makes the check in the delete for it being deleted, pointless
we should just check for a response code
going to tweet Julien and copy you in
l

limited-rainbow-51650

02/25/2020, 8:50 AM
@broad-dog-22463 do you run the pulumi-gitlab tests against your internal Gitlab setup? Is this the Premium or Ultimate tier? In these tiers projects are “soft”-deleted and your 10m timeout won’t suffice.
b

broad-dog-22463

02/25/2020, 8:50 AM
these are against public Gitlab SaaS
even so, it's a pointless check in the Delete as some uses may not have the time changed
l

limited-rainbow-51650

02/25/2020, 8:51 AM
But paid account probably with Silver or Gold tier?
b

broad-dog-22463

02/25/2020, 8:53 AM
probably
Even so, the func should work the same across all tiers
l

limited-rainbow-51650

02/25/2020, 8:55 AM
No longer it seems. Functionality is different based on the tier you are on.
b

broad-dog-22463

02/25/2020, 8:56 AM
What I mean is, the TF provider has to work the same across them all
unless there will be different providers for different levels
l

limited-rainbow-51650

02/25/2020, 9:04 AM
This is going to become difficult as the D in CRUD is no longer deterministic in behavior. 😞
b

broad-dog-22463

02/25/2020, 9:12 AM
yeah... that's a bad decision on their part IMO