Channels
announcements
automation-api
aws
azure
blog-posts
built-with-pulumi
cloudengineering
cloudengineering-support
content-share
contribex
contribute
docs
dotnet
finops
general
getting-started
gitlab
golang
google-cloud
hackathon-03-19-2020
hacktoberfest
install
java
jobs
kubernetes
learn-pulumi-events
linen
localstack
multi-language-hackathon
office-hours
oracle-cloud-infrastructure
plugin-framework
pulumi-ai
pulumi-cdk
pulumi-cloud
pulumi-crosscode
pulumi-deployments
pulumi-kubernetes-operator
pulumiverse
python
registry
status
testingtesting123
testingtesting321
typescript
welcome
workshops
yaml
Title
c
colossal-australia-65039
02/23/2021, 10:55 PMhow can i submit a PR? the readme says to run
make travis_pull_requestmoved to GitHub Actionsb
billowy-army-68599
02/23/2021, 11:49 PMfor pulumi/pulumi ?
c
colossal-australia-65039
02/23/2021, 11:51 PMyup
b
billowy-army-68599
02/23/2021, 11:57 PMjust submit the PR, we'll update the contributing doc. We used to run the tests in travis, we do them in GHA now and have an improved workflow
do you have your code in a fork?
c
colossal-australia-65039
02/23/2021, 11:58 PMah i didn't fork it. I'll submit it from a fork, thanks!
b
billowy-army-68599
02/23/2021, 11:59 PM👍
ping me if you need help!
😄 1
c
colossal-australia-65039
02/24/2021, 12:24 AMi didn't add any tests for my small addition. if that's fine the PR is ready for
/run-acceptance-testsb
billowy-army-68599
02/24/2021, 12:30 AMwhoa! this is incredible, thank you so much Mike! can you DM me your email address please? we'd love to send you a token of gratitude
❤️ 1