https://pulumi.com logo
Title
c

colossal-australia-65039

02/23/2021, 10:55 PM
how can i submit a PR? the readme says to run
make travis_pull_request
but it just outputs
moved to GitHub Actions
b

billowy-army-68599

02/23/2021, 11:49 PM
for pulumi/pulumi ?
c

colossal-australia-65039

02/23/2021, 11:51 PM
yup
b

billowy-army-68599

02/23/2021, 11:57 PM
just submit the PR, we'll update the contributing doc. We used to run the tests in travis, we do them in GHA now and have an improved workflow
do you have your code in a fork?
c

colossal-australia-65039

02/23/2021, 11:58 PM
ah i didn't fork it. I'll submit it from a fork, thanks!
b

billowy-army-68599

02/23/2021, 11:59 PM
👍
ping me if you need help!
😄 1
c

colossal-australia-65039

02/24/2021, 12:24 AM
i didn't add any tests for my small addition. if that's fine the PR is ready for
/run-acceptance-tests
https://github.com/pulumi/pulumi/pull/6413
b

billowy-army-68599

02/24/2021, 12:30 AM
whoa! this is incredible, thank you so much Mike! can you DM me your email address please? we'd love to send you a token of gratitude
❤️ 1