https://pulumi.com
Join Slack
This message was deleted.
# contribute
s
This message was deleted.
m
Also the 
CONTRIBUTING.md
seems inaccurate, unless I’m missing a step. https://github.com/pulumi/pulumi-awsx/blob/master/CONTRIBUTING.md 
make test_all
does not exist in the 
Makefile
and the main https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md is not very relevant to developing for this nodejs package.
b
Hey @millions-furniture-75402 You are really correct here and we don't have a good set of docs for this area - would you mind raising a bug in pulumi/pulumi and point this out so we can get it rectified? Thanks!
m
Certainly, I’ll make a note to write something up. Here’s my first Pulumi contribution https://github.com/pulumi/pulumi-awsx/pull/654
b
I just saw it! Thanks so much 🙂 I will get it reviewed this week - I absolutely love when community members send us PRs - especially since we've not made it easy to do so!
👍 2
I will ensure that we get better CONTRIBUTING.md docs added
👍 1
m
b
thank you so much!!
m
There is another issue I’ve had to work-around, that I would like to open a PR for, but as I began work on the feature branch, I realized the problem is bigger than my specific use case.
For my use case, 
awsx.s3.metrics.numberOfObjects
requires storageType 
AllStorageTypes
— but there are many other storage types not supported referenced here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/metrics-dimensions.html
2 Views
Open in Slack
PreviousNext
Powered by

Pulumi Community

No matter how you like to participate in developer communities, Pulumi wants to meet you there. If you want to meet other Pulumi users to share use-cases and best practices, contribute code or documentation, see us at an event, or just tell a story about something cool you did with Pulumi, you are part of our community.

Powered by