This message was deleted.
# contribute
s
This message was deleted.
b
hey there! any branch name is fine, we run the tests on PR, so just send the PR upstream and ping us and we'll take a look!
thanks so much for contributing!
h
Thanks! Was a really tiny fix (#311). Would really appreciate hearing feedback if I missed anything I should be doing for a PR so I know for future
b
@helpful-book-29233 unfortunately your fix won't quite work, because the SDK folder is automatically generated from the resource itself 😞
h
Ah might have jumped the gun a bit then, any chance you could please point me in the right direction for what controls that?
b
it'll need to be a codegen update, which is out my wheelhouse ability unfortunately...
h
I'm confused about how the codgen works. I saw a previous PR which had edited the same line of code, was that edit generated from this schema?
b
i could be wrong, let's leave the PR open and I'll get some from eng tomorrow to take a look
thanks for diggign in
h
Ok cheers, I've just never worked with codegen before so will be happy to learn more if I've got things mixed up
r
That's not a codegen file, it's handwritten - so you're all good @helpful-book-29233
👍 1
It's one of the few overlays in the docker provider... most of the rest of it is generated but these files are handwritten: https://github.com/pulumi/pulumi-docker/blob/master/provider/resources.go#L141-L147
❤️ 1