Hi Team, I was looking at this <issue> , based of...
# contributeq
quiet-tent-15043
08/09/2025, 2:23 PMHi Team, I was looking at this issue , based of the issue comments I think I can add two lines at the bottom (diagnostics section). one showing if deployment was successful, and if errors faced show errors count at the bottom with messg "deployment faced errors". should i make a PR on this ? or I am missing something.
e
echoing-dinner-19531
08/09/2025, 7:21 PMSounds reasonable, feel free to open a PR. I think a lot of display tests will need updating but we can help with that.
👍 1
q
quiet-tent-15043
08/09/2025, 7:58 PMare display tests a part of engine lifecycle tests ?
e
echoing-dinner-19531
08/10/2025, 9:29 AMyup
echoing-dinner-19531
08/10/2025, 9:31 AMcd pkg/engine/lifecycle && go test ./...
You'll probably see a load of diff errors
You can set PULUMI_ACCEPT=1 to regenerate them when the test runs, but awkwardly provider UUIDs aren't deterministic so if you just run go test it will regen pretty much every single display and event test, so you can kinda need to use
-run=TestName👍 1
q
quiet-tent-15043
09/21/2025, 8:57 PMopened a PR on this.
quiet-tent-15043
09/24/2025, 7:55 PM@echoing-dinner-19531I did the all changes , I Just need to fix tests now but they are a lot 😶
e
echoing-dinner-19531
09/24/2025, 7:59 PMIf you run tests with the env var PULUMI_ACCEPT=1 most will rewrite their expected snapshot values for you. A lot easier then editing lots of files by hand.
q
quiet-tent-15043
09/24/2025, 8:09 PMalright LMT.
quiet-tent-15043
09/26/2025, 8:36 AM@echoing-dinner-19531 changes done and display Tests fixed.
quiet-tent-15043
09/26/2025, 5:00 PM@echoing-dinner-19531 can you hit acceptance tests once on this PR
3 Views