Hi Team, I was looking at this <issue> , based of...
# contribute
q
Hi Team, I was looking at this issue , based of the issue comments I think I can add two lines at the bottom (diagnostics section). one showing if deployment was successful, and if errors faced show errors count at the bottom with messg "deployment faced errors". should i make a PR on this ? or I am missing something.
e
Sounds reasonable, feel free to open a PR. I think a lot of display tests will need updating but we can help with that.
👍 1
q
are display tests a part of engine lifecycle tests ?
e
yup
cd pkg/engine/lifecycle && go test ./... You'll probably see a load of diff errors You can set PULUMI_ACCEPT=1 to regenerate them when the test runs, but awkwardly provider UUIDs aren't deterministic so if you just run go test it will regen pretty much every single display and event test, so you can kinda need to use
-run=TestName
to re-run just the tests that have error diffs
👍 1