If you export the state to a file, what is the value?

v8***

We added additional metadata to the state files in some of the later versions of v8 that helps avoid some of these type errors in the migrators.

(we have 10's of these stacks)

Same error, even with

pulumi up --refresh --run-program

(Even if it would have worked, we don’t run --refresh in our production workflows)

Was using

v8.32.1

before

(Pulumi 3.190.0)

(Same in Pulumi 3.199.0)

In `-v=9`:

I1003 14:40:43.886103   15736 eventsink.go:59] [DEBUG] Attributes before migration: map[string]interface {}{"autoclass":[]interface {}{}, "cors":[]interface {}{}, "custom_placement_config":[]interface {}{}, "default_event_based_hold":false, "effective_labels":map[string]interface {}{}, "enable_object_retention":false, "encryption":[]interface {}{}, "force_destroy":false, "hierarchical_namespace":[]interface {}{map[string]interface {}{"enabled":false}}, "id":"READCTED", "ip_filter":[]interface {}{}, "labels":map[string]interface {}{}, "lifecycle_rule":[]interface {}{}, "location":"REDACTED", "logging":[]interface {}{}, "name":"REDACTED", "project":"REDACTED", "project_number":"REDACTED", "public_access_prevention":"inherited", "requester_pays":false, "retention_policy":[]interface {}{map[string]interface {}{"is_locked":true, "retention_period":"315360000"}}, "rpo":interface {}(nil), "self_link":"<https://www.googleapis.com/storage/v1/b/REDACTED>", "soft_delete_policy":[]interface {}{map[string]interface {}{"effective_time":"2024-03-01T08:00:00.000Z", "retention_duration_seconds":"604800"}}, "storage_class":"STANDARD", "terraform_labels":map[string]interface {}{}, "time_created":"2023-01-11T11:43:36.161Z", "timeouts":interface {}(nil), "uniform_bucket_level_access":true, "updated":"2024-05-26T07:42:28.024Z", "url":"<gs://REDACTED>", "versioning":[]interface {}{map[string]interface {}{"enabled":false}}, "website": []interface {}{}}

Notice:

"retention_period":"315360000"

Is a string before migration 🤔

Seems like it should be a json.Number: https://go.dev/play/p/-vUhXnqVvrY

Actually I think I understand where the string type is coming from - the new type after the change in my Go code, since I now need to:

policy = &storage.BucketRetentionPolicyArgs{
			IsLocked: pulumi.BoolPtr(true),
			RetentionPeriod: pulumi.Sprintf("%d", 60*60*24*365*10),
		}

But that’s weird, I would assume it should only upgrade the state

If I'm reading this part of the patch correctly, it looks like the upgrade transform is assuming the retention period is always a number and needs to be converted to a string. That would unfortunately disallow us from passing strings, but fine if TypeScript (and I assume Go) allowed us to pass an integer as that retention period which is not possible because it was switched to a string in the type definitions. In other words, the upgrade and type definitions are out of alignment. Does that sound like a reasonable diagnosis? If so, it seems like checking if the value is a string and just leaving it alone in the upgrader would work? https://github.com/GoogleCloudPlatform/magic-modules/pull/15000/files#diff-79c9f7a54630f5a6a6b43bb88a5699b2[…]3d3df216ca7eef820663617bcddR1575-R1582

I tried recreating this issue with a simple pulumi program, but was not able to do so in isolation. My process was to create a bucket with an integer retention period under gcp v8, upgrade to v9, switch the retention period to the string representation, then re-up. Under v9, pulumi reported no changes to be made. This is what I'd hope would happen in my actual program, but I continue to get the error above about an unexpected string in v9. If anyone else has any ideas here, I'd appreciate the help.

Two full go projects pointing to the same stack

Opened issue: https://github.com/pulumi/pulumi-gcp/issues/3432

But from

8.32.1

it doesn’t

But I am not sure how this is “acceptable” for real world use cases

Actually allow me to correct myself Two step upgrade does not work

8.32.1

->

8.41.1

->

v9

I assume it has something to do with

__pulumi_raw_state_delta

object in the state? It is only available if the object was initially created with

8.41.1

but does not appear when upgrading from

8.32.1

to

8.41.1

. So still broken @miniature-twilight-47355

This is all too “brittle” I wonder if there could just be a fix in next versions that would solve it backwards, this seems like something that affects every terraform provider schema upgrade

https://github.com/pulumi/pulumi-terraform-bridge/pull/2945 - is where the fix started

@enough-garden-22763 hope its okay to tag you here

This fix unfortunately does not help users that have states produced by an older version of the provider without the information encoded, which may be affecting you here, but again a repro would be appreciated so we chase this down formally! Thanks for your patience.