Hi, I am looking for some help with Pulumi docker_...
# general
o
Hi, I am looking for some help with Pulumi docker_build provider: https://github.com/pulumi/pulumi-docker-build/issues/678 - appreciate your help 🙏
s
Hi @orange-orange-5698, I'm seeing the same issue. If you'd like to try opening a PR for this, that'd be awesome!
This'll be a good place to start to learn about how to contribute: https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md
o
Thank you @steep-plastic-74107 for reviewing and confirming the issue. I am thinking to add
shouldImageRebuildOnChange: bool = true
in
secrets
to allow users to mark
shouldImageRebuildOnChange
field as false when needed. However,
secrets
type is currently
map[string]string
which means the change won't be backward-compatible if I change it to:
Copy code
map[string]Secret

type Secret struct {
	// Value is the direct secret value
	Value string `pulumi:"value,optional"`

	// If false, the docker is not rebuilt if the value of secret changes. This is useful in cases where secret is a short-lived token which changes on every run but the image shouldn't be rebuilt
	ShouldImageRebuildOnChange bool `pulumi:"shouldImageRebuildOnChange,optional"`
}
s
Hmm, yea, would it be possible to add a new option instead that takes the keys of secrets that don't need a rebuild? It's a little less elegant, but it could help make things more backwards-compatible
o
Hi @steep-plastic-74107, I have raised the PR: https://github.com/pulumi/pulumi-docker-build/pull/683 Not sure if it would be reviewed automatically or not, if not, could you please notify the maintainers to review the PR 🙏
s
Yea, thank you! Most of our team is off for Thanksgiving, but I’ll let folks know to take a look on Monday :)
o
Hi @steep-plastic-74107, kind reminder: will appreciate a review (and possibly a new release) today.
s
Sounds good! I'll ask the team to take a look
f
Hi @orange-orange-5698 I'm your Account Manager and wondered if it would be worth us setting up a call with my Senior Solutions Architect to explore this further alongside your requirements? If so I can PM you to arrange.
o
Hi Dipali, nice to meet you. For now, I wait and see if I can get my suggested change approved and merged. If that happens then that would be fantastic for us, if not, I will let you know. How does that sound for you?
f
I think it would be good to connect either way! I can help escalate this change happening, especially once we understand more about your use case. I'll pm you anyway 🙂