Hey, I have made some changes to k8s helm provid...
# contribute
f
Hey, I have made some changes to k8s helm provider to handle the hooks in case we're in render to folder only. https://github.com/pulumi/pulumi-kubernetes/pull/4426 anyone is able to review and suggest a way forward if that can be merged !? it's already working in my flow but i am compiling the plugin manually and use it rather than pulling it from upstream
b
Hey thanks for that - I can see you tagged one of my colleagues in it so I'll ping the team in our internal slack
🙏 1
f
@shy-arm-32391 Is there any chance you or anyone could review this PR ?
s
hi! thank you for the pull request! As I mentioned on Kubernetes Slack, this issue has been difficult to prioritize. As the linked issue shows, it's a not insignificant feature that is not currently on our roadmap.
f
Yeah make sense and i can agree with your point. As you said the linked issue is trying to solve the complex issue but the PR i raised is just about the local rendering and does not touch the linked issue directly , it just make sure to render the hooks when render to folder is set and the hook implementation is still something that needs a proper planning and design. i made it working anyway as i am compiling the patch on every build which is a bit painful for me not being able to use upstream directly. If you think this PR can be merged it is a huge help for me as I am investing on Pulumi in my rearchitecture project and want to expand it but this becomes a serious pain to maintain a patch.
s
update: I took a look today. Just-rendering is a much smaller lift and we can probably take it but it probably needs to be opt-in.
👀 1
f
changed it to opt-in model on the chart rather than provider.
s
running tests right now! this looks good! Thank you for your patience.
1