hi team, my org was onboarding `@pulumi/digitaloc...
# contribute
a
hi team, my org was onboarding
@pulumi/digitalocean
and we learned that the
token
field inside of the DO provider object is not marked as a secret (learned that the hard way .. 😅 ). i created a PR to mark the field as a secret, any eyes on it would be greatly appreciated! 🙏 github.com/pulumi/pulumi-digitalocean/pull/1420
s
Thanks for catching this. I've added a request for review and fired off some of the checks. Feel free to ping me here if review is not forthcoming.
a
Np, glad to help! not sure if this is expected but the comment-triggered acceptance tests seem to have passed but github.com/pulumi/pulumi-digitalocean/…/90418403084?pr=1420 failed (
run-acceptance-tests / License Check / License Check (pull_request)
)
l
@agreeable-minister-84341 the change to
resources.go
is not enough. Can you run
make clean provider build_sdks
on your branch and also commit the changes made to the generated language SDKs?
a
@limited-rainbow-51650 just pushed that up, thank you for the heads up