https://pulumi.com logo
#contribute
Title
# contribute
s

sparse-gold-10561

03/10/2022, 6:52 PM
Hello, I noticed an AWS managed policy was missing and added it here: https://github.com/pulumi/pulumi-aws/pull/1833 Is this the correct process for contributing?
b

billowy-army-68599

03/10/2022, 7:11 PM
@sparse-gold-10561 sort of
s

sparse-gold-10561

03/10/2022, 7:13 PM
😞
b

billowy-army-68599

03/10/2022, 7:13 PM
@sparse-gold-10561 i edited my comment, i was wrong!
b

billowy-army-68599

03/10/2022, 7:17 PM
you'll need to add it
resources.go
and then regenerate the schema using
make
s

sparse-gold-10561

03/10/2022, 7:17 PM
ok let me mess with it and i'll submit the updated changes
b

billowy-army-68599

03/10/2022, 8:25 PM
@sparse-gold-10561 you missed the step to regen the schemas, I pushed a commit to your branch, i hope you don't mind
if you want to regen yourself, just run
make
from within the repo. if not, close your PR and your commit is in my branch
s

sparse-gold-10561

03/10/2022, 8:28 PM
I dont think my pulumi development environment is ready.. i'll close my PR.
It was throwing some errors building unrelated to this change
ohwell.. thanks!
s

stocky-restaurant-98004

03/14/2022, 2:33 PM
@sparse-gold-10561 For future reference, the minimal steps after changing resources.go are:
Copy code
make tfgen
make build_sdks
Then you can push your branch. If you hit any additional hurdles, please let me know. If we can make our docs clearer (and I'm sure there's room for improvement), this is valuable feedback!
s

sparse-gold-10561

03/14/2022, 2:34 PM
For me its building the entire development environment within a Windows Subsystem for Linux environment. It seems like I need both pulumi and pulumi-aws built before I can run the make commands.. I was having problems getting them all to build.
s

stocky-restaurant-98004

03/14/2022, 2:36 PM
Pulumi itself would just need to be on your `PATH`:
brew install pulumi
(or maybe there's some sort of sync between WSL and your PS prompt - not sure as I haven't used WSL).
s

sparse-gold-10561

03/14/2022, 2:38 PM
i was planning to try it again this week and see if i can setup a full environment... if so ill make notes and see about creating a doc to help others replicate the environment.
s

stocky-restaurant-98004

03/14/2022, 3:29 PM
@sparse-gold-10561 Thanks so much! I'll be sure to include your feedback in a GH issue for our team since enabling the community eco system is a major ongoing theme for us.
s

sparse-gold-10561

03/18/2022, 2:49 PM
I was able to get WSL to fully build pulumi-aws.. however, when i run make, it keeps trying to switch all the .go files to v4.. from v5.. I did the go mod tidy but that doesnt seem to help.. any ideas?
Copy code
// import (
// 	"<http://github.com/pulumi/pulumi-aws/sdk/v5/go/aws|github.com/pulumi/pulumi-aws/sdk/v5/go/aws>"
// )
>>

"<http://github.com/pulumi/pulumi-aws/sdk/v4/go/aws|github.com/pulumi/pulumi-aws/sdk/v4/go/aws>"
3 Views