Channels
#typescript
Title
q
quiet-crayon-85132
08/10/2023, 9:21 PMHello, I am following the tutorial here: https://www.pulumi.com/docs/clouds/aws/guides/ecr/#consuming-a-private-repository-from-ecs
But I get the following error when referencing
image: image.imageUri, Copy code
Diagnostics:
aws:ecs:TaskDefinition (service):
error: 1 error occurred:
* failed creating ECS Task Definition (service-b4d7f7a8): ClientException: Container.image repository should be 255 characters or less.l
little-cartoon-10569
08/10/2023, 9:26 PMBased on experience, I'm going to make a guess: your task definition is using a JSON.stringify and image.imageUri is in there without a
pulumi.interpolateApologies if I'm way off the mark! It has happened to me, and to many people whose code I have reviewed. So I'm guessing 🙂
q
quiet-crayon-85132
08/10/2023, 9:29 PMmmm i am not doing a json stringify, im using crosswalk, straight from the example
l
little-cartoon-10569
08/10/2023, 9:35 PMI'll look in the AWSX code to see what it does. Are you using awsx classic/0.40.1? Or awsx new?
f
full-eve-52536
08/10/2023, 9:36 PMI'm not sure that pulumi knows what
image.imageUriq
quiet-crayon-85132
08/10/2023, 9:36 PMit is
Copy code
"@pulumi/awsx": "^1.0.0",l
little-cartoon-10569
08/10/2023, 9:36 PMIt should know. It does in all other cases: that's what outputs are for. However, awsx does not always follow Pulumi's best practices.
f
full-eve-52536
08/10/2023, 9:37 PMWould the
applyl
little-cartoon-10569
08/10/2023, 9:38 PMapply is pulumi.interpolate. It would be needed only if the big JSON object is turning into a string. If it is handled as a complete object and all Input<>s in it are handled correctly, then it should work correctly.
Give me 5 minutes to find and review the code.
q
quiet-crayon-85132
08/10/2023, 9:38 PMthank you so much!
f
full-eve-52536
08/10/2023, 9:40 PMthe
image:interpolatel
little-cartoon-10569
08/10/2023, 9:46 PMThe documentation uses "string" to mean "Input<string>", so it would be handled correctly if that was all that was involved. (I've complained about that on many occasions, they won't change it back 😞 )
However, that's not all that's involved. There are multiple levels of CustomResource and ComponentResource through the awsx and aws code. It looks like the image property is not used directly: it is put into a ContainerDefinition in the awsx code. Still reading....
I see two levels of apply() being using at the point, which should be enough? https://github.com/pulumi/pulumi-awsx/blob/dad5462435286498bc86168c91c0d801482dbcba/awsx/ecs/fargateTaskDefinition.ts#L122
However, I don't understand why it's explicitly applying cpu, memory and memoryReservation. What about all the other properties, including image?
Line 152 should do everything that's needed:
Copy code
const containerString = containerDefinitions.apply((d) => JSON.stringify(d));And the easiest way is to use apply/interpolate yourself, in your code. If it fixes it, then Alex's/my guesses are correct, and you need to interpolate.
So instead of using
image: image.imageUri Copy code
image: pulumi.interpolate`image.imageUri`q
quiet-crayon-85132
08/10/2023, 9:52 PMdoes it not need the
${} Copy code
image: pulumi.interpolate`${image.imageUri}`,f
full-eve-52536
08/10/2023, 9:53 PMI had no idea that some of these resource modules were written that way (with
applyq
quiet-crayon-85132
08/10/2023, 9:54 PMthank you both for the insights
the example on the pulumi documentation is confusing as it has
image: image.imageUril
little-cartoon-10569
08/10/2023, 9:59 PMIt might do @quiet-crayon-85132. Sorry, been called to a meeting, can't check right now 🙂
q
quiet-crayon-85132
08/10/2023, 9:59 PMall good, thanks again!
update to close the loop on this, i updated awsx to
1.0.41.0.12 Views