https://pulumi.com logo
#pulumiverse
Title
# pulumiverse
b

bulky-hamburger-30930

10/17/2023, 11:43 AM
Could anyone review and apply this PR? I need to add CEO of my company to help me with 2 pulumi providers we manage. https://github.com/pulumiverse/infra/pull/114 @limited-rainbow-51650 @many-telephone-49025
m

many-telephone-49025

10/17/2023, 11:45 AM
The file content look good to me, not sure why your build is broken though!
b

bulky-hamburger-30930

10/17/2023, 11:53 AM
Hm.. I'm just unlucky today 👀. Not this time then
Actually it's blocking me... @limited-rainbow-51650 could you please take a look?
I see the problem now. It uses secrets from my fork https://stackoverflow.com/questions/73866908/github-actions-main-repository-secret-not-picked-up-from-pull-request-build @many-telephone-49025 Could you please move my changes to your repo and create a PR? Or give me write permissions so I could create a PR inside of original repo? https://github.com/pulumiverse/infra/pull/114
m

many-telephone-49025

10/17/2023, 2:50 PM
let me check this but i need time
as i have to attend some meetings
b

bulky-hamburger-30930

10/17/2023, 2:51 PM
Take your time. Thank you
@many-telephone-49025 A kind reminder. Could you please take a look?
m

many-telephone-49025

10/19/2023, 9:59 AM
@bulky-hamburger-30930 done ->https://github.com/pulumiverse/infra/pull/118 @limited-rainbow-51650 and @busy-journalist-6936 please check the PR.
b

bulky-hamburger-30930

10/19/2023, 5:01 PM
@limited-rainbow-51650 @many-telephone-49025 I see that the change was applied. But no result. loopingrage user is not even present in pulumiverse
l

limited-rainbow-51650

10/19/2023, 5:03 PM
@bulky-hamburger-30930 the change was applied correctly, but Jose should have received an invite email from Github which he hasn't accepted yet. Once accepted, he will show up nicely.
b

bulky-hamburger-30930

10/19/2023, 5:03 PM
Ah.. Thank you
@limited-rainbow-51650 Could you please take a look on my CEO's permissions? I expected that he will be able to help me with my PRs but his approval does not mean anything. I usually happens when people have no enough access. https://github.com/pulumiverse/pulumi-zitadel/pull/16
@many-telephone-49025 Could you please approve? https://github.com/pulumiverse/pulumi-zitadel/pull/16 Since my CEO's approval does not count 😞
@limited-rainbow-51650 I will create
master
to bypass branch protection rules. And when you have time we will fix permissions and return everything back. I just cannot wait days for review. I need to release features in hours.
@limited-rainbow-51650 do you have any time to look at my CEO's permissions? He approves PRs but his approval is not enough to merge.
l

limited-rainbow-51650

11/28/2023, 2:03 PM
@bulky-hamburger-30930 I have fixed José's membership to the zitadel provider. Every repository is configured to require a review from a code owner, but then Jose needs to be added to the
CODEOWNERS
file in each repo. Can you create a PR for each, add
loopingrage
to this and assign it to me for review? https://github.com/pulumiverse/pulumi-astra/blob/main/CODEOWNERS https://github.com/pulumiverse/pulumi-zitadel/blob/main/CODEOWNERS