https://pulumi.com logo
#contribute
Title
# contribute
l

lively-crayon-44649

09/22/2022, 12:07 PM
PR to bump
pulumi-cloudflare
to support Cloudflare Pages now that upstream Terraform does https://github.com/pulumi/pulumi-cloudflare/pull/287
s

stocky-restaurant-98004

09/22/2022, 1:41 PM
Were those resources just flat-out missing from the provider?
l

lively-crayon-44649

09/22/2022, 1:58 PM
They only got added in Terraform in the last release or so, so there was nothing to map to, is my understanding.
The provider recently bumped the TF dependency though so they are now available -- this PR just maps them.
s

stocky-restaurant-98004

09/22/2022, 1:58 PM
Yeah, I saw that. That's a mistake on our end. I'll alert the team to your PR.
l

lively-crayon-44649

09/22/2022, 1:59 PM
What's the mistake? Not adding when the dependency was bumped?
No worries if so -- the TF change is literally only a few weeks old (if that)!
We're just literally about to deploy some pages so I figured worth a shot hacking them in
s

stocky-restaurant-98004

09/22/2022, 1:59 PM
Yeah. There's env vars that should be set that will throw an exception if a resource is not mapped.
l

lively-crayon-44649

09/22/2022, 2:00 PM
Oh interesting. That's a nice guard.
s

stocky-restaurant-98004

09/22/2022, 2:00 PM
Yeah - we need to set them in GHA so that this stuff gets caught.
In the meanwhile, do you need to use a local version of the provider to get unstuck, and if so, do you need any help with that?
l

lively-crayon-44649

09/22/2022, 2:01 PM
We're not blocked per se -- I was wary of doing something like that since I would guess it's a bit of effort, and if the PR is mergeable in the next week or so then it could be a bad use of time (all of this is hypothetical)
s

stocky-restaurant-98004

09/22/2022, 2:03 PM
Well, if you are hot to trot, you can do
make provider
and then add the generated
bin/pulumi-resource-cloudflare
to your PATH. Then do
make build_sdks
and link to the local copy of the SDK in your language of choice.
l

lively-crayon-44649

09/22/2022, 2:05 PM
Ah I see -- so basically vendoring that SDK in our repo until we can point to a new release?
s

stocky-restaurant-98004

09/22/2022, 2:05 PM
Yes, but you also need the provider binary in your path.
So it may not be totally feasible for shared development. I can see about getting a release out today.
l

lively-crayon-44649

09/22/2022, 2:06 PM
No rush, honestly -- thanks for all the help, Josh!
s

stocky-restaurant-98004

09/22/2022, 2:10 PM
You are most welcome, and thank you for your contribution!