This message was deleted.

sparse-intern-71089

10/22/2018, 9:39 PM

This message was deleted.

creamy-potato-29402

10/22/2018, 9:40 PM

@tall-monitor-77779 it uses the standard build infrastructure so

make test_all

should work

creamy-potato-29402

10/22/2018, 9:40 PM

also much of pulumi/pulumi contributing.md should apply here as well.

tall-monitor-77779

10/22/2018, 9:40 PM

yeah just reading thru that now thanks!

tall-monitor-77779

10/22/2018, 9:41 PM

cloud.Service

is killing me

tall-monitor-77779

10/22/2018, 9:41 PM

see https://pulumi-community.slack.com/archives/C84L4E3N1/p1539775969000100

creamy-potato-29402

10/22/2018, 9:43 PM

yeah that makes sense

creamy-potato-29402

10/22/2018, 9:43 PM

I don’t know much about the cloud package though so I’m not sure how much I can help……

tall-monitor-77779

10/22/2018, 9:43 PM

I love it and hate it

tall-monitor-77779

10/22/2018, 9:44 PM

such a powerful abstraction, removing the need to manually create VPC’s, Security Groups etc.

tall-monitor-77779

10/22/2018, 9:44 PM

and its ALMOST perfect

white-balloon-205

10/22/2018, 9:44 PM

Cc @lemon-spoon-91807 who may be able to help with some of the questions here.

creamy-potato-29402

10/22/2018, 9:45 PM

Yeah, personally, I find this to be true of most new noun-based abstractions. 🙂

tall-monitor-77779

10/22/2018, 9:45 PM

I’ve been down a rabbit hole today with it

creamy-potato-29402

10/22/2018, 9:45 PM

same could be said of Kubernetes

Service

and

Ingress

tall-monitor-77779

10/22/2018, 9:45 PM

true

creamy-potato-29402

10/22/2018, 9:45 PM

In the limit the complexity of new nouns becomes the transitive closure of all subcomponents that it abstracts.

tall-monitor-77779

10/22/2018, 9:45 PM

thanks @white-balloon-205 will look forward to chatting wit him

lemon-spoon-91807

10/22/2018, 9:46 PM

Hi there 🙂

tall-monitor-77779

10/22/2018, 9:46 PM

Hola

tall-monitor-77779

10/22/2018, 9:47 PM

I have 2 requirements: 1. not to publish my service externally 2. to use DNS for service discovery

tall-monitor-77779

10/22/2018, 9:47 PM

I’ve used

cloud-aws:usePrivateNetwork: "true"

tall-monitor-77779

10/22/2018, 9:48 PM

which is fair enough, tho I think we really should be able to pass such parameters when constructing the

cloud.Service

lemon-spoon-91807

10/22/2018, 9:48 PM

slack crashed 🙂

tall-monitor-77779

10/22/2018, 9:48 PM

there is lots of spagetti there, you wind up chasing your arse to figure out what

getOrCreateNetwork

and

getCluster

does

tall-monitor-77779

10/22/2018, 9:49 PM

then you find out that you can alter its behaviour with parameters

lemon-spoon-91807

10/22/2018, 9:49 PM

yup. the feedback makes sense

lemon-spoon-91807

10/22/2018, 9:50 PM

note: i'm not a particular expert in this area. @white-balloon-205 is there a reason that hte Network portion of cloud.Service is not something that a user can supply when making a Service?

tall-monitor-77779

10/22/2018, 9:50 PM

so I thought, I’ll folk and PR to add

useLoadBalancer?: boolean;

ServiceArguments

tall-monitor-77779

10/22/2018, 9:52 PM

and then skip

createLoadBalancer

aws/service.ts#723

if this is set to

false

lemon-spoon-91807

10/22/2018, 9:52 PM

my concern there would be:

lemon-spoon-91807

10/22/2018, 9:52 PM

if we don't create a load balancer, later on other stuff will not be happy

tall-monitor-77779

10/22/2018, 9:52 PM

but then got into a whole world of pain (see above)

lemon-spoon-91807

10/22/2018, 9:53 PM

like line: 237

tall-monitor-77779

10/22/2018, 9:53 PM

const hostname = info.host.dnsName;

lemon-spoon-91807

10/22/2018, 9:53 PM

yes

tall-monitor-77779

10/22/2018, 9:54 PM

umm

lemon-spoon-91807

10/22/2018, 9:54 PM

i'm just trying to compute out hte downstream impact of not having a load balancer

tall-monitor-77779

10/22/2018, 9:54 PM

I think @white-balloon-205 agreed the other day that DNS for service discover was a good thing

lemon-spoon-91807

10/22/2018, 9:55 PM

(this is not an area of expertise for me)

tall-monitor-77779

10/22/2018, 9:55 PM

that was going to be my next task after disabling LB

lemon-spoon-91807

10/22/2018, 9:55 PM

sorry, i'm not questioning the ask 🙂 or hte desire. I'm just trying to figure out what would need to happen in the code to make this feasible 🙂

tall-monitor-77779

10/22/2018, 9:55 PM

yeah thats fair, np

lemon-spoon-91807

10/22/2018, 9:56 PM

i.e. it doesn't look as simple as just 'do not create the load balancer'. since code a few steps down looks lke it will just crash.

lemon-spoon-91807

10/22/2018, 9:57 PM

however, it looks like this is just being done to create some environment variables. so maybe it's fine to just not do that

lemon-spoon-91807

10/22/2018, 9:57 PM

So: question for you. If you try this locally (i.e. just comment out the line that makes the load balance, and comment out the line that uses that later on to create environment variables), do things otherwise work for you?

lemon-spoon-91807

10/22/2018, 9:58 PM

do you get the resultant set of infrastructure you want, confiured properly for your needs?

tall-monitor-77779

10/22/2018, 9:58 PM

good question, lets see

lemon-spoon-91807

10/22/2018, 9:58 PM

Ok 🙂

lemon-spoon-91807

10/22/2018, 9:58 PM

let me know what you discover/learn

lemon-spoon-91807

10/22/2018, 9:58 PM

because that can feed into an appropriate PR with a suitable design to address things here

tall-monitor-77779

10/22/2018, 9:59 PM

(never easy going thru the TS generated JS) 😕

lemon-spoon-91807

10/22/2018, 10:00 PM

it shouldn't be too bad 🙂 it's just an NPM package. so you can whack away to your heart's content 😄

lemon-spoon-91807

10/22/2018, 10:04 PM

can i help with anything else? or is this a reasonable starting point to just see if we can get enough info to proceed?

tall-monitor-77779

10/22/2018, 10:17 PM

sorry deleting a

aws:ec2:Subnet

seems to be taking an absolute age

tall-monitor-77779

10/22/2018, 10:18 PM

just waiting for that before I run with the LB commented out

lemon-spoon-91807

10/22/2018, 10:19 PM

indeed, tens of minutes sometimes

tall-monitor-77779

10/22/2018, 10:32 PM

yeah so

function getEndpoints

isn’t happy, needs

dnsName

so going into another rabbit hole

tall-monitor-77779

10/22/2018, 10:32 PM

so yeah, thats not a simple change to skip the LB create

lemon-spoon-91807

10/22/2018, 10:33 PM

ah yup. that's another location

lemon-spoon-91807

10/22/2018, 10:33 PM

getEndpoints shouldn't be too hard to update though

tall-monitor-77779

10/22/2018, 10:34 PM

I’m defeated! lost an whole day on this 😕

tall-monitor-77779

10/22/2018, 10:34 PM

looks like I’m gunna have to manually construct an ECS cluster with much the same code as

cloud.Service

😞

lemon-spoon-91807

10/22/2018, 10:35 PM

oh no! that sucks 😞 I'm going to open a bug for us to track this. I'm a little wary about it as i'm not sure the entire implications of not having a load balancer

lemon-spoon-91807

10/22/2018, 10:35 PM

but it's something we can try to make better in the future

lemon-spoon-91807

10/22/2018, 10:36 PM

Also, what's your github alias, so i can tag you in the issue? Thanks!

tall-monitor-77779

10/22/2018, 10:36 PM

I think its really worth putting some attention to, its a great feature of pulumi, but its in need of some simplification and less black magic

tall-monitor-77779

10/22/2018, 10:37 PM

danny-waite

is my github user

lemon-spoon-91807

10/22/2018, 10:37 PM

Ok. opened https://github.com/pulumi/pulumi-cloud/issues/634 to track this.

👍 1

lemon-spoon-91807

10/22/2018, 10:59 PM

Working on a potential PR now for Danny to try out

Open in Slack

Previous Next

Pulumi Community

No matter how you like to participate in developer communities, Pulumi wants to meet you there. If you want to meet other Pulumi users to share use-cases and best practices, contribute code or documentation, see us at an event, or just tell a story about something cool you did with Pulumi, you are part of our community.