https://pulumi.com logo
Title
c

cuddly-leather-18640

06/21/2021, 4:24 PM
@broad-dog-22463 do you mind explaining why the go tests for pulumi docker are being skipped since the pulumi v3 upgrade? https://github.com/pulumi/pulumi-docker/commit/8d68bed36c1b4d7a6c108c579dd15692627e2243#diff-2e4fffe32720b3d310b4336[…]d9e0d82b418299817fdf42a29fR28 I’m trying to use
CacheFrom
in the go sdk but it’s broken and now I’m looking to fix that.
I’d appreciate any pointers you have on getting it fixed
b

broad-dog-22463

06/21/2021, 4:26 PM
We have a race condition that is causing issues - see https://github.com/pulumi/pulumi-docker/runs/2763541149?check_suite_focus=true#step:20:228 for the issue we are running into
They were skipped at major upgrade version as v2 of the api is not compatible with v3 of the api and our testing framework can’t handle that very well
But not they can be renabled again but doing that gives this error above
c

cuddly-leather-18640

06/21/2021, 4:28 PM
ah I see. If I make a PR to fix the CacheFrom problem, will it get accepted since the testing framework can’t verify if the fix works?
b

broad-dog-22463

06/21/2021, 4:40 PM
I can verify it locally before we can merge so it would be more than welcome
c

cuddly-leather-18640

06/21/2021, 7:18 PM
awesome! I’ll do my best to get that out today but I’m totally new to the codebase so we might have to iterate a few times
are there docs I can follow to test locally on my own? That might speed up the iteration process
gentle ping on ^ @broad-dog-22463
b

broad-dog-22463

06/22/2021, 8:52 PM
Will get it reviewed tomorrow! Sorry first day back after vacation
🙏 1
Hey @cuddly-leather-18640 so I am looking at your PR right now...
ok, so the pulumiTypes are actually automated 😕 So any codegen changes will blog your changes away
I need to dig in and find out what is causing those to be generated as though types
c

cuddly-leather-18640

06/24/2021, 3:20 PM
ah, damn! My bad for not noticing that. Is there anything I can do to help support you?
b

broad-dog-22463

06/24/2021, 4:14 PM
no no 🙂
you've helped a lot here already
c

cuddly-leather-18640

06/24/2021, 4:45 PM
glad to hear, I’d really like to get this fix out since it’s slowing down my CI pipelines a lot
b

broad-dog-22463

06/24/2021, 5:22 PM
@cuddly-leather-18640 so the good news here is that this is not autogenerated code
this is a handwritten component
😄
c

cuddly-leather-18640

06/24/2021, 7:35 PM
oh nice, so is my PR useful?
friendly ping 🙂