https://pulumi.com logo
Join Slack
Powered by
This message was deleted.
# pulumi-cloud
s
This message was deleted.
l
I will loop this by one of our engineers.
w
Thanks! Should I open a support ticket?
l
Please do. The Github App is part of our service implementation, so please file it here: https://github.com/pulumi/service-requests/
h
@white-chef-55657 if you're comfortable including some information on the issue like your pulumi org and github org that would help me debug. if you're not comfortable sharing that you can DM me
w
I have a support ticket opened #2085 with all the relevant information
I see @many-telephone-49025 is on it
can I get an update from anyone on this? @many-telephone-49025 @hallowed-photographer-31251?
l
@white-chef-55657 our guess for now is that not all environment variables are passed to the called reusable workflow. Can you verify if the 
PULUMI_CI_*
environment variables are passed to the called workflow from the parent workflow? You see the complete list of these env vars here: https://github.com/pulumi/pulumi/issues/11425
w
ah, that could be it - let me look
• Any environment variables set in an 
env
context defined at the workflow level in the caller workflow are not propagated to the called workflow. For more information about the 
env
context, see “Context and expression syntax for GitHub Actions.”
https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/reusing-workflows
👀 1
should I pass ALL the vars listed in the issue you sent? or just the few PULUMI_CI ?
l
The easiest is indeed to pass all env vars. But the 
PULUMI_CI_*
vars are the ones we rely on mainly.
w
see the quote above, it’s a known limitation of reusable workflows, cannot share all env vars but can pass individually will add the 
PULUMI_CI_*
ones to see if that fixes it, thanks!
• “PULUMI_CI_BRANCH_NAME” • “PULUMI_CI_BUILD_ID” • “PULUMI_CI_BUILD_NUMBER” • “PULUMI_CI_BUILD_TYPE” • “PULUMI_CI_BUILD_URL” • “PULUMI_CI_PULL_REQUEST_SHA” • “PULUMI_CI_SYSTEM”
l
Credit to @hallowed-photographer-31251 because he went into the correct direction.
🙌 1
w
actually - I’m thinking about this again, and why would those even exist in the “caller” workflow?
perhaps you’re looking for the 
GITHUB_
ones ?
this is the caller workflow, you probably need the GITHUB info about the PR that created that event
l
Good thinking. From the general ones, we might convert these to our Pulumi ones. Next to the 
GITHUB_
ones, I also would pass the 
CI_*
and 
GIT_*
ones.
w
ok, will give that a shot
is your github app open source?
it will probably show what it’s using from the events
l
No, the code of our Github app is part of our cloud service.
m
Interesting, didn't know that the env variables are not propagated down... Thanks @white-chef-55657 for the link!
w
Passing CI_ GITHUB_ and GIT_ did not solve it
As checks are properly added and marked successful I don't think it's an issue with the env vars, Your GitHub app gets the information it needs to mark the checks but not post comments Could someone on your end look at the logs and see what's missing ?
hello?
h
@white-chef-55657 fwiw a lot of us are out on holiday today and tomorrow so we'll be slow to respond. great catch on env vars not getting propagated -- we should figure out how to do this and document it in the action. the cli is open source and that's the piece responsible for detecting these env vars and sending them as part of the update. these ones are picked up from github actions -- did you already try all of them? there might be some additional ones required https://github.com/pulumi/pulumi/blob/10dd3d09233fb7cfd9688ef8305add0203002615/sdk/go/common/util/ciutil/github_actions.go#L52
👍 1
Pulumi still adds status checks on the PRs, but not comments - any idea how to troubleshoot this?
i just noticed this -- if you are getting status checks that tells me we do have all the info we need to comment on your PR. what i think is happening here: if the update doesn't make any changes (no resources updated / created / deleted / replaced) it will omit the comment in the interest of keeping noise down on your PR. it's worth looking at your updates to see if that might be the case. if that is the issue here and you would prefer to always get a comment even when nothing has changed, please file an issue on https://github.com/pulumi/service-requests/ and we can look into making this behavior configurable.
w
I don’t get any comment - ever
I used to get comments, but it recently stopped
I checked the env vars are in fact available in the shared workflow, as expected they are there
would appreciate some proper feedback, the support ticket is open and didn’t get a response at all yet.. @many-telephone-49025
m
Hi @white-chef-55657, how about a short call and maybe screen share 2morrow? Most of the engineers are on their Thanksgiving holidays but maybe I can see your code/workflows and add more infos to your ticket?
w
anytime, will DM you - thanks
👍 1
m
Awesome!
Hi @white-chef-55657, Here is my first test Pulumi Program: https://github.com/dirien/github-pulumi-action/pull/2 Init: Fresh stack Content: simple stack (CIVO vm) and a reusable workflow, So far the comments get produces
I will now extend the code with using the Pulumi automation API to see how it continues
h
@white-chef-55657 can you tell me the version of Pulumi your action was using on a PR that got comments and a PR that didn't? trying to narrow down if perhaps something in the cli changed recently. if you're using pulumi/actions, in the github logs you should see something like "Configured range: ^3 Matched version: v3.48.0" for the pulumi/actions step
w
hi @hallowed-photographer-31251, not using pulumi/actions because we use the automation api using 3.48.0 thanks @many-telephone-49025 for the reproduce, will take a look!
@many-telephone-49025 I see you implemented both automation api and actions we don’t use 
pulumi/actions
let’s remove that?
m
its already on if: false
w
oh I missed that, let me look again
I see you have 
COMMENT_ON_PR
- where is that used?
m
I tried different things because it’s not working! No comments for me neither when I use automation API
w
oh, I thought you did get it to work
m
without automation api and callable workflow it works
w
ok - so you’re able to reproduce the issue?
m
Yes
w
sorry for the misunderstanding
ok - how else can I help then?
m
I will discuss this with engineering, as we have now a very boiled down example to examine
Thanks for your patience Omer!
🙌 1
h
@white-chef-55657 just to confirm, you were able to get comments with pulumi version 3.48.0, and you're still using that version but now not getting comments?
w
@hallowed-photographer-31251 see the repo that @many-telephone-49025 has for details
👍 1
@hallowed-photographer-31251 @many-telephone-49025 any update on this?
m
Hi @white-chef-55657 just came out of an investigation session with @hallowed-photographer-31251! We made good progress on analysing the issue and Bryce is following up for possible solution with his team. Yeah! 🎉
w
that’s awesome, thanks for the update!
@many-telephone-49025 @hallowed-photographer-31251 any solution in sight?
m
Hi @white-chef-55657, I think @hallowed-photographer-31251 took the issue to the engineering team. There was recently an update in the issue from him. https://github.com/pulumi/pulumi/issues/11574
w
right, and I responded is there any way to prioritize this?
m
We try to prioritise the open issue with the engineering team, but can't make any commitments on timing.
w
hi @many-telephone-49025 please pass on the message that since we don’t have these previews, combined with the overall performance issues - we have no reason to keep using pulumi service backend and will be switching to S3
m
Hi Omer, we should talk after the holiday days! 🙂
Nevertheless I will pass this internally as you requested. I am sure we will find a solution
w
@hallowed-photographer-31251 @limited-rainbow-51650 any update on this? I ended up implementing a replacement from scratch using the 
plans.json
in case that’s helpful to anyone else I’m happy to share the solution
l
@white-chef-55657 I wouldn’t know as I’ve been away from work for 4 weeks. @many-telephone-49025, were you able to follow up?
w
I was told it’s not a priority right now - which is very disappointing.. with this feature now implemented locally we don’t have any other use for the pulumi service and will be offboarding soon
notifications suddenly started appearing today - did you guys fix anything?
by the way - my implementation catches changes that yours doesn’t 😛 happy to share my code if needed
👀 1
m
CC: @hallowed-photographer-31251
h
we deliberately omit some operations from PR comments to keep the noise down.
w
Ok But did you fix anything that is started working ?
h
we did recently fix an issue where comments weren't being posted to "internal" repositories -- did that fix it for you?
ah sorry i see above that it did
34 Views
Open in Slack
PreviousNext
Powered by