howdy wave I recently noticed we re no longer getting commen

Question

howdy wave I recently noticed we re no longer getting comments on PRs I don t think anything changed with the github integration the only major change I can think of is that we switched to reusable workflows Pulumi still adds status checks on the PRs but not comments any idea how to troubleshoot this

limited-rainbow-51650 · Answer

I will loop this by one of our engineers

white-chef-55657 · Answer

Thanks Should I open a support ticket

limited-rainbow-51650 · Answer

Please do The Github App is part of our service implementation so please file it here <https github com pulumi service requests >

hallowed-photographer-31251 · Answer

< white chef 55657> if you re comfortable including some information on the issue like your pulumi org and github org that would help me debug if you re not comfortable sharing that you can DM me

white-chef-55657 · Answer

I have a support ticket opened 2085 with all the relevant information

white-chef-55657 · Answer

I see < many telephone 49025> is on it

white-chef-55657 · Answer

can I get an update from anyone on this < many telephone 49025> < hallowed photographer 31251>

limited-rainbow-51650 · Answer

< white chef 55657> our guess for now is that not all environment variables are passed to the called reusable workflow Can you verify if the `PULUMI CI ` environment variables are passed to the called workflow from the parent workflow You see the complete list of these env vars here

white-chef-55657 · Answer

ah that could be it let me look

white-chef-55657 · Answer

gt Any environment variables set in an `env` context defined at the workflow level in the caller workflow are not propagated to the called workflow For more information about the `env` context see

white-chef-55657 · Answer

should I pass ALL the vars listed in the issue you sent or just the few PULUMI CI

limited-rainbow-51650 · Answer

The easiest is indeed to pass all env vars But the `PULUMI CI ` vars are the ones we rely on mainly

white-chef-55657 · Answer

see the quote above it s a known limitation of reusable workflows cannot share all env vars but can pass individually will add the `PULUMI CI ` ones to see if that fixes it thanks

white-chef-55657 · Answer

PULUMI CI BRANCH NAME PULUMI CI BUILD ID PULUMI CI BUILD NUMBER PULUMI CI BUILD TYPE PULUMI CI BUILD URL PULUMI CI PULL REQUEST SHA PULUMI CI SYSTEM

limited-rainbow-51650 · Answer

Credit to < hallowed photographer 31251> because he went into the correct direction

white-chef-55657 · Answer

actually I m thinking about this again and why would those even exist in the caller workflow

white-chef-55657 · Answer

perhaps you re looking for the `GITHUB ` ones

white-chef-55657 · Answer

this is the caller workflow you probably need the GITHUB info about the PR that created that event

limited-rainbow-51650 · Answer

Good thinking From the general ones we might convert these to our Pulumi ones Next to the `GITHUB ` ones I also would pass the `CI ` and `GIT ` ones

white-chef-55657 · Answer

ok will give that a shot

white-chef-55657 · Answer

is your github app open source

white-chef-55657 · Answer

it will probably show what it s using from the events

limited-rainbow-51650 · Answer

No the code of our Github app is part of our cloud service

many-telephone-49025 · Answer

Interesting didn t know that the env variables are not propagated down Thanks < white chef 55657> for the link

white-chef-55657 · Answer

Passing CI GITHUB and GIT did not solve it

white-chef-55657 · Answer

As checks are properly added and marked successful I don t think it s an issue with the env vars Your GitHub app gets the information it needs to mark the checks but not post comments Could someone on your end look at the logs and see what s missing

white-chef-55657 · Answer

hello

hallowed-photographer-31251 · Answer

< white chef 55657> fwiw a lot of us are out on holiday today and tomorrow so we ll be slow to respond great catch on env vars not getting propagated we should figure out how to do this and document it in the action the cli is open source and that s the piece responsible for detecting these env vars and sending them as part of the update these ones are picked up from github actions did you already try all of them there might be some additional ones required

hallowed-photographer-31251 · Answer

gt Pulumi still adds status checks on the PRs but not comments any idea how to troubleshoot this i just noticed this if you are getting status checks that tells me we do have all the info we need to comment on your PR what i think is happening here if the update doesn t make any changes no resources updated created deleted replaced it will omit the comment in the interest of keeping noise down on your PR it s worth looking at your updates to see if that might be the case if that is the issue here and you would prefer to always get a comment even when nothing has changed please file an issue on <https github com pulumi service requests > and we can look into making this behavior configurable

white-chef-55657 · Answer

I don t get any comment ever

white-chef-55657 · Answer

I used to get comments but it recently stopped

white-chef-55657 · Answer

I checked the env vars are in fact available in the shared workflow as expected they are there

white-chef-55657 · Answer

would appreciate some proper feedback the support ticket is open and didn t get a response at all yet < many telephone 49025>

many-telephone-49025 · Answer

Hi < white chef 55657> how about a short call and maybe screen share 2morrow Most of the engineers are on their Thanksgiving holidays but maybe I can see your code workflows and add more infos to your ticket

white-chef-55657 · Answer

anytime will DM you thanks

many-telephone-49025 · Answer

Awesome

many-telephone-49025 · Answer

Hi < white chef 55657> Here is my first test Pulumi Program Init Fresh stack Content simple stack CIVO vm and a reusable workflow So far the comments get produces

many-telephone-49025 · Answer

I will now extend the code with using the Pulumi automation API to see how it continues

hallowed-photographer-31251 · Answer

< white chef 55657> can you tell me the version of Pulumi your action was using on a PR that got comments and a PR that didn t trying to narrow down if perhaps something in the cli changed recently if you re using pulumi actions in the github logs you should see something like Configured range ^3 Matched version v3 48 0 for the pulumi actions step

white-chef-55657 · Answer

hi < hallowed photographer 31251> not using pulumi actions because we use the automation api using 3 48 0 thanks < many telephone 49025> for the reproduce will take a look

white-chef-55657 · Answer

< many telephone 49025> I see you implemented both automation api and actions we don t use `pulumi actions` let s remove that

many-telephone-49025 · Answer

its already on if false

white-chef-55657 · Answer

oh I missed that let me look again

white-chef-55657 · Answer

I see you have `COMMENT ON PR` where is that used

many-telephone-49025 · Answer

I tried different things because it s not working No comments for me neither when I use automation API

white-chef-55657 · Answer

oh I thought you did get it to work

many-telephone-49025 · Answer

without automation api and callable workflow it works

white-chef-55657 · Answer

ok so you re able to reproduce the issue

many-telephone-49025 · Answer

Yes

white-chef-55657 · Answer

sorry for the misunderstanding

white-chef-55657 · Answer

ok how else can I help then

many-telephone-49025 · Answer

I will discuss this with engineering as we have now a very boiled down example to examine

many-telephone-49025 · Answer

Thanks for your patience Omer

hallowed-photographer-31251 · Answer

< white chef 55657> just to confirm you were able to get comments with pulumi version 3 48 0 and you re still using that version but now not getting comments

white-chef-55657 · Answer

< hallowed photographer 31251> see the repo that < many telephone 49025> has for details

white-chef-55657 · Answer

< hallowed photographer 31251> < many telephone 49025> any update on this

many-telephone-49025 · Answer

Hi < white chef 55657> just came out of an investigation session with < hallowed photographer 31251> We made good progress on analysing the issue and Bryce is following up for possible solution with his team Yeah tada

white-chef-55657 · Answer

that s awesome thanks for the update

white-chef-55657 · Answer

< many telephone 49025> < hallowed photographer 31251> any solution in sight

many-telephone-49025 · Answer

Hi < white chef 55657> I think < hallowed photographer 31251> took the issue to the engineering team There was recently an update in the issue from him

white-chef-55657 · Answer

right and I responded is there any way to prioritize this

many-telephone-49025 · Answer

We try to prioritise the open issue with the engineering team but can t make any commitments on timing

white-chef-55657 · Answer

hi < many telephone 49025> please pass on the message that since we don t have these previews combined with the overall performance issues we have no reason to keep using pulumi service backend and will be switching to S3

many-telephone-49025 · Answer

Hi Omer we should talk after the holiday days slightly smiling face

many-telephone-49025 · Answer

Nevertheless I will pass this internally as you requested I am sure we will find a solution

white-chef-55657 · Answer

< hallowed photographer 31251> < limited rainbow 51650> any update on this I ended up implementing a replacement from scratch using the `plans json` in case that s helpful to anyone else I m happy to share the solution

limited-rainbow-51650 · Answer

< white chef 55657> I wouldn t know as I ve been away from work for 4 weeks < many telephone 49025> were you able to follow up

white-chef-55657 · Answer

I was told it s not a priority right now which is very disappointing with this feature now implemented locally we don t have any other use for the pulumi service and will be offboarding soon

white-chef-55657 · Answer

notifications suddenly started appearing today did you guys fix anything

white-chef-55657 · Answer

by the way my implementation catches changes that yours doesn t stuck out tongue happy to share my code if needed

many-telephone-49025 · Answer

CC < hallowed photographer 31251>

hallowed-photographer-31251 · Answer

we deliberately omit some operations from PR comments to keep the noise down

white-chef-55657 · Answer

Ok But did you fix anything that is started working

hallowed-photographer-31251 · Answer

we did recently fix an issue where comments weren t being posted to internal repositories did that fix it for you

hallowed-photographer-31251 · Answer

ah sorry i see above that it did